Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PU distribution covering the envelope of min bias xsecs #21207

Merged
merged 1 commit into from Nov 9, 2017

Conversation

capalmer85
Copy link
Contributor

of 65.6 to 78 mB
https://capalmer.web.cern.ch/capalmer/2017/Q4/PUProjections/

This is marginally different from what we discussed via email earlier today.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21207/1860

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

A new Pull Request was created by @capalmer85 for master.

It involves the following packages:

SimGeneral/MixingModule

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @ebrondol this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@franzoni
Copy link

franzoni commented Nov 8, 2017

hello @capalmer85

I gather this : https://capalmer.web.cern.ch/capalmer/2017/Q4/PUProjections/newPUPro.png
is the distribution you're committing here.

And that it's obtained from the envelope of all the histos coming from the family of systematic variations https://capalmer.web.cern.ch/capalmer/2017/Q4/PUProjections/rangeOfXsec.png ?

That would do well.

Please, place the PR also for the 94 branch.

@civanch
Copy link
Contributor

civanch commented Nov 8, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24269/console Started: 2017/11/08 13:05

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21207/24269/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2903670
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2903498
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram bins added: 0.0 ( 22 files compared)
  • Checked 107 log files, 8 edm output root files, 26 DQM output files

@civanch
Copy link
Contributor

civanch commented Nov 9, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9e0e4dc into cms-sw:master Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants