Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for phase 1 geometry and further automation of APE tool #21301

Merged
merged 5 commits into from Nov 29, 2017

Conversation

mteroerd
Copy link
Contributor

@mteroerd mteroerd commented Nov 14, 2017

backport of #20889

This includes some small fixes, which up until now I had to manually include in each now CMSSW environment that I set up.

Parts of the APE tool still had the phase 0 geometry included. Changes were made to
Alignment/APEEstimation/macros/DrawIteration.C and
Alignment/APEEstimation/macros/commandsDrawIteration.C
to use phase 1 geometry.

  • This only affects the plotting tools

Other changes include a small automation of the APE determination workflow in the following files:
Alignment/APEEstimation/cfgTemplatesData/run15Iterations.bash
Alignment/APEEstimation/cfgTemplatesData/run10Iterations.bash
Alignment/APEEstimation/cfgTemplates/batchSubmitTemplate.tcsh

  • Before, one had to manually specify a sleeping time between iterations, waiting for batch jobs to finish
  • Now, as soon as all batch jobs of an iteration have finished, the sleeping is ended
    The old workflow is kept in the following files for now:

Alignment/APEEstimation/cfgTemplatesData/manual_run15Iterations.bash
Alignment/APEEstimation/cfgTemplatesData/manual_run10Iterations.bash

Finally, the deprecated use of ​CondCore.​DBCommon.CondDBCommon_cfi was removed from
Alignment/APEEstimation/test/SkimProducer/skimProducer_cfg.py.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 14, 2017

A new Pull Request was created by @mteroerd for CMSSW_9_4_X.

It involves the following packages:

Alignment/APEEstimation

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor

arunhep commented Nov 15, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24457/console Started: 2017/11/15 17:17

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21301/24457/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2779661
  • DQMHistoTests: Total failures: 106
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2779384
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 107 log files, 8 edm output root files, 26 DQM output files

@ghellwig
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3bfbc16 into cms-sw:CMSSW_9_4_X Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants