New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes for phase 1 geometry and further automation of APE tool #21301
Conversation
A new Pull Request was created by @mteroerd for CMSSW_9_4_X. It involves the following packages: Alignment/APEEstimation @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #20889
This includes some small fixes, which up until now I had to manually include in each now CMSSW environment that I set up.
Parts of the APE tool still had the phase 0 geometry included. Changes were made to
Alignment/APEEstimation/macros/DrawIteration.C and
Alignment/APEEstimation/macros/commandsDrawIteration.C
to use phase 1 geometry.
Other changes include a small automation of the APE determination workflow in the following files:
Alignment/APEEstimation/cfgTemplatesData/run15Iterations.bash
Alignment/APEEstimation/cfgTemplatesData/run10Iterations.bash
Alignment/APEEstimation/cfgTemplates/batchSubmitTemplate.tcsh
The old workflow is kept in the following files for now:
Alignment/APEEstimation/cfgTemplatesData/manual_run15Iterations.bash
Alignment/APEEstimation/cfgTemplatesData/manual_run10Iterations.bash
Finally, the deprecated use of CondCore.DBCommon.CondDBCommon_cfi was removed from
Alignment/APEEstimation/test/SkimProducer/skimProducer_cfg.py.