New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.0.X] Update of MC misalignment scaler tool #21304
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks |
The tests are being triggered in jenkins. |
A new Pull Request was created by @ghellwig (Gregor Mittag) for master. It involves the following packages: Alignment/TrackerAlignment @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
@@ -25,6 +25,7 @@ | |||
) | |||
) | |||
process.mcMisalignmentScaler.pullBadModulesToIdeal = False | |||
process.mcMisalignmentScaler.outlierPullToIdealCut = 0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ghellwig can you please add a comment here explaining the choice of this threshold?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @ghellwig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arunhep sorry, your question slipped through the cracks.
This cfg file is just an arbitrary example and as you can see above the default given in fillDescriptions
is a negative value, i.e. outlier modules are not pulled to ideal.
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Addendum to #21264.