Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0.X] Update of MC misalignment scaler tool #21304

Merged
merged 2 commits into from Dec 1, 2017

Conversation

ghellwig
Copy link

Addendum to #21264.

@ghellwig
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21304/1991

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 14, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24433/console Started: 2017/11/14 18:56

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ghellwig (Gregor Mittag) for master.

It involves the following packages:

Alignment/TrackerAlignment

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21304/24433/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2716578
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2716401
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.04000000011 KiB( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@@ -25,6 +25,7 @@
)
)
process.mcMisalignmentScaler.pullBadModulesToIdeal = False
process.mcMisalignmentScaler.outlierPullToIdealCut = 0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghellwig can you please add a comment here explaining the choice of this threshold?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @ghellwig

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arunhep sorry, your question slipped through the cracks.
This cfg file is just an arbitrary example and as you can see above the default given in fillDescriptions is a negative value, i.e. outlier modules are not pulled to ideal.

@arunhep
Copy link
Contributor

arunhep commented Dec 1, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 17f48b9 into cms-sw:master Dec 1, 2017
@ghellwig ghellwig deleted the mc-misalignment-scaler branch December 19, 2017 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants