Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep islandPhoton related collections via HI eras (94X) #21311

Merged
merged 1 commit into from Nov 19, 2017

Conversation

ttrk
Copy link
Contributor

@ttrk ttrk commented Nov 15, 2017

stores PhotonCore and corrected SuperCluster collections corresponding to islandPhotons.
This PR is for HI-related eras, in particular pp_on_XeXe_2017, ppRef_2017.
These collections are necessary for SC information and their addition was omitted in the previous PR #21069 (94X).
This PR is intended for xexe re-reco.
Backport of #21310

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ttrk (Kaya Tatar) for CMSSW_9_4_X.

It involves the following packages:

RecoEcal/Configuration
RecoEgamma/Configuration

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @rovere, @argiro, @lgray, @varuns23 this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24441/console Started: 2017/11/15 08:33

@perrotta
Copy link
Contributor

abort test

@cmsbuild
Copy link
Contributor

Jenkins tests are aborted.

@perrotta
Copy link
Contributor

please test workflow 149.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24443/console Started: 2017/11/15 08:38

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21311/24443/summary.html

There are some workflows for which there are errors in the baseline:
10042.0 step 5
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2406837
  • DQMHistoTests: Total failures: 72
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2406603
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 102 log files, 8 edm output root files, 25 DQM output files

@ttrk ttrk changed the title keep islandPhoton related collections via era modification (94X) keep islandPhoton related collections via HI eras (94X) Nov 16, 2017
@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit f8fbf9e into cms-sw:CMSSW_9_4_X Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants