add EventGenerationFailure exit code

[perrozzi]

to catch missing or exceeding LHE events

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21328/2024

[cmsbuild]

A new Pull Request was created by @perrozzi for master.

It involves the following packages:

FWCore/Utilities
GeneratorInterface/LHEInterface

@smuzaffar, @efeyazgan, @Dr15Jones, @perrozzi, @thuer, @cmsbuild, @govoni can you please review it and eventually sign? Thanks.
@mkirsano, @makortel, @felicepantaleo, @wddgit, @Martin-Grunewald, @agrohsje, @alberto-sanchez, @ebrondol this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24477/console Started: 2017/11/16 14:43

[Dr15Jones]

Please also add an entry here
https://github.com/cms-sw/cmssw/blob/master/FWCore/Utilities/src/EDMException.cc#L43

[cmsbuild]

The code-checks are being triggered in jenkins.

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21328/2029

[Dr15Jones]

+1

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

Pull request #21328 was updated. @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please check and sign again.

[perrozzi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

-1

Tested at: 4c82b2d

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c620eaf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21328/24477/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21328/24477/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21328/24477/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafExamples had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c620eaf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21328/24477/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21328/24477/git-merge-result

[cmsbuild]

Comparison job queued.

[Dr15Jones]

The unit test failures are from the IB, not this pull request.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21328/24477/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2832924
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2832745
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.19000000004 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[Dr15Jones]

The comparison differences are only with the number of entries in the MessageLogger. That value is known to vary based on exact when other modules run with respect to the modules that the MessageLogger is explicitly waiting upon.

[perrozzi]

@bendavid fyi

[davidlange6]

merge