Make the HLT vertex filters robust to L3Muon duplicates - 92X backport

[aboletti]

Backport of #21331

Two HLT filters, used in some BPH HLT paths, has been updated to be robust to the presence of duplicates in the L3Muon collection.

The changes affect the part of the code that selects the 2 muons and 1 (2) track(s) matched with the three (four) tracks used to build the vertex.
They include:

• veto to the selection of two identical muons
• reduction of the exception message to the cases in which not enough matching muons/tracks are found

[cmsbuild]

A new Pull Request was created by @aboletti for CMSSW_9_2_X.

It involves the following packages:

HLTrigger/btau

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@imarches, @acaudron, @Martin-Grunewald, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

• Backported from Make the HLT vertex filters robust to L3Muon duplicates #21331

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24480/console Started: 2017/11/16 16:31

[cmsbuild]

+1
Tested at: 1bd5443
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21333/24480/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
94488b5
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21333/24480/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21333/24480/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21333/24480/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 2163005
• DQMHistoTests: Total failures: 29360
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2133473
• DQMHistoTests: Total skipped: 172
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
• Checked 94 log files, 8 edm output root files, 23 DQM output files

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[Martin-Grunewald]

@aboletti
Please fix the 92X PR as well!

[cmsbuild]

Pull request #21333 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

[aboletti]

@Martin-Grunewald
sorry, I was forgetting to push this guy

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24519/console Started: 2017/11/18 10:04

[cmsbuild]

+1
Tested at: 480e414
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21333/24519/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
94488b5
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21333/24519/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21333/24519/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21333/24519/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 2162937
• DQMHistoTests: Total failures: 59061
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2103704
• DQMHistoTests: Total skipped: 172
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
• Checked 94 log files, 8 edm output root files, 23 DQM output files

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1