use deterministic seed for time smearing producers

[kpedro88]

Resolves #20621

The TrackTimeValueMapProducer now uses STL <random> with the PRNG reseeded for every event. The seed is based on the event run/lumi/event numbers and the chi2 value of the first track. (The last quantity is added to ensure different seeding when the producer is called with different collections. Currently two versions of it exist in the Phase2 reco sequences, one for general tracks and another for GSF electron tracks.)

I checked the t() value of the 4D vertices after running 20034.2 with step3 on 1 thread vs 4 threads. In the default release, I see a change; with this PR, there is no change.

Should this be backported to 93X? It runs in RECO, while with 93X we only plan to do re-miniAOD.

attn: @lgray, @bendavid

[cmsbuild]

The code-checks are being triggered in jenkins.

[kpedro88]

sigh, a conflict arose in the past ~hour. Rebasing...

[kpedro88]

Actually, will wait for the next IB to rebase.

[kpedro88]

assign upgrade

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21354/2049

[cmsbuild]

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

IOMC/RandomEngine
SimTracker/TrackAssociation

@smuzaffar, @civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@abbiendi, @makortel, @sdevissc, @GiacomoSguazzoni, @jhgoh, @VinInn, @wddgit, @rovere, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

Your PR is unmergeable. Please have a look and possibly rebase it.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21354/2061

[cmsbuild]

Pull request #21354 was updated. @smuzaffar, @civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24518/console Started: 2017/11/18 06:38

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24639/console Started: 2017/11/22 20:50

[cmsbuild]

Pull request #21354 was updated. @perrotta, @civanch, @mdhildreth, @cmsbuild, @kpedro88, @slava77 can you please check and sign again.

[cmsbuild]

+1
Tested at: afb40b3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21354/24639/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0a3cf1a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21354/24639/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21354/24639/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21354/24639/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2717769
• DQMHistoTests: Total failures: 172
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2717421
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.14999999999 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[civanch]

+1

[perrotta]

+1

• Usage of a different random engine modifies the Phase2 events with timing, as for wf 20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19 in the jenkins tests
• Differences are compatible with a modified random sequence
• A few examples follow:
  
  

[kpedro88]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1

[davidlange6]

+1