Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Geant4 physics lists #21360

Merged
merged 5 commits into from Nov 21, 2017
Merged

Updated Geant4 physics lists #21360

merged 5 commits into from Nov 21, 2017

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Nov 17, 2017

Updated alternative Geant4 Physics Lists which may be used for various studies. 8 obsolete lists removed, 3 new added. Now most part of alternative Physics Lists use only components from geant4 libraries instead of CMS custom.

Local EM physics builder are updated according to recent modifications in Geant4.

Header files of CMS Physics Lists are renamed according to the CMS code conversion (.h instead of .hh).

Modifications better correspond to the coming new Geant4 10.4 but are working with the current Geant4 10.2.

The default Physics List FTFP_BERT_EMM is not changed, so unchanged results are expected.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@civanch
Copy link
Contributor Author

civanch commented Nov 17, 2017

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21360/2058

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24512/console Started: 2017/11/17 20:26

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21360/24512/summary.html

There are some workflows for which there are errors in the baseline:
10042.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 20997 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2675252
  • DQMHistoTests: Total failures: 94990
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 2580083
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.940000000039 KiB( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21360/2070

@civanch
Copy link
Contributor Author

civanch commented Nov 20, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 20, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24533/console Started: 2017/11/20 11:02

@cmsbuild
Copy link
Contributor

Pull request #21360 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@civanch
Copy link
Contributor Author

civanch commented Nov 20, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21360/24533/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2833444
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2833265
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.40999999995 KiB( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3468977 into cms-sw:master Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants