Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnlineDQM : Remove unneeded histograms from uGMT #21364

Merged
merged 2 commits into from Dec 13, 2017

Conversation

stahlleiton
Copy link
Contributor

Solves the JIRA Ticket: https://its.cern.ch/jira/browse/CMSLITDPG-322

Description:

  • Remove some muon AtVtx plots and rename the BXvsProcessor plots used in the uGMT L1T Online DQM workspace.

  • Add a boolean flag to create or not the muon AtVtx plots for the Intermediate muons in the uGMT L1T Online DQM workspace.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21364/2067

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @stahlleiton (Andre Stahl) for master.

It involves the following packages:

DQM/L1TMonitor

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor

Hi @jfernan2 could you launch the tests for this PR please? The backport is already tested and deployed at P5.

@dmitrijus
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24694/console Started: 2017/11/27 14:29

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21364/24694/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2604375
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2604203
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.45000000007 KiB( 13 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@thomreis
Copy link
Contributor

Hi @dmitrijus ,
This PR removes unneeded MEs. How can the histogram memory increase?

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

the dqm script (or cmsbots interoperation of its output) seems to have a gitter at the 1kb level. if this PR really changes only online dqm, then 0 change is expected..

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 5dae57d into cms-sw:master Dec 13, 2017
@stahlleiton stahlleiton deleted the L1TDPGJIRA322_Master branch March 7, 2018 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants