Include ForwardDetRod.h in RBorderFinder.h

[Teemperor]

We reference ForwardDetRing in this header, so we also need to
include the associated header to make this header parsable
on its own.

[Teemperor]

Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21400/2107

[cmsbuild]

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

RecoMuon/DetLayers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @jhgoh, @echapon, @calderona, @HuguesBrun, @battibass, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24585/console Started: 2017/11/21 16:51

[cmsbuild]

-1

Tested at: 36935c4

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
893188d
0707ff5
bbddd85
ed2b195
12605de
3441962
c792deb
8d25c3d
84e2869
54ee550
3468977
eeb8263
32307fd
34b0dcf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21400/24585/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21400/24585/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21400/24585/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafExamples had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
893188d
0707ff5
bbddd85
ed2b195
12605de
3441962
c792deb
8d25c3d
84e2869
54ee550
3468977
eeb8263
32307fd
34b0dcf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21400/24585/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21400/24585/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21400/24585/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3523 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2746803
• DQMHistoTests: Total failures: 9379
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2737247
• DQMHistoTests: Total skipped: 177
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.11000000003 KiB( 22 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[perrotta]

please test with #21186
(Trying to see if less merge commits are merged together this time, and we can get rid as such to the differences seen by jenkins, which are not expected due to this PR alone)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24616/console Started: 2017/11/22 16:18

[cmsbuild]

+1
Tested at: 36935c4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21400/24616/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
645119b
5780cd4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21400/24616/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21400/24616/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21400/24616/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2833444
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2833265
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.16999999999 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[slava77]

to make this header parsable on its own.

@Teemperor @Dr15Jones
I thought that this was going to affect only packages from FWLite.
Is this actually extending to the full repository?

[slava77]

+1

for #21400 36935c4

• implemented as described; this is technical outside of the scope of getting the header parsable on its own
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[Dr15Jones]

modules will be applied to all CMSSW, or at least all parts seen by ROOT.

[davidlange6]

+1