[10.0.x] Add dump plot of AlignPCLThreshold in the payload inspector #21417
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CondCore/PCLConfigPlugins @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
| #################### | ||
| # Test Gains | ||
| #################### | ||
| /afs/cern.ch/user/c/condbpro/public/BROWSER_PI/getPayloadData.py \ |
There was a problem hiding this comment.
hi @ggovi - can you make that PR for getPayloadData now?
There was a problem hiding this comment.
what are the use cases for this thing? The password of the direct oracle access won't be available to the users anyways...
There was a problem hiding this comment.
@ggovi, as of now, mostly for those who have direct oracle (i.e. developers) to test the code when making changes and also to use the tool in local check-outs, which is still useful to produce plots.
Anyway, what prevents to provide direct oracle (reading) access to to the cms-bot to make this become part of a unit test? Incidentally I think we could use the same mechanism to test the O2Os.
There was a problem hiding this comment.
Provide read-access to the cms-bot means essentially store the password in the repository... Not viable.
There was a problem hiding this comment.
The O2O tests could be done with frontier+sqlite... Oracle is not required
There was a problem hiding this comment.
@mmusich , cmsbuild has grid certificate which we use for cmsweb authentication
There was a problem hiding this comment.
@smuzaffar yes thanks I imagined so, but there's not password associated with it?
There was a problem hiding this comment.
@mmusich , yes, no password is associated with it.
There was a problem hiding this comment.
@smuzaffar OK, thank you.
There was a problem hiding this comment.
Maybe I should rephrase: "The O2O tests" like all the tests requiring access to the database "MUST be implemented with frontier/sqlite". There is a deployment/distribution issue for the password. No way to store it in github.
Also, the OCCI problem is in... OCCI. It's an external, I don't think we should have the ambition to test our externals. But we should have the ambition to choose them according to some criteria of maintenance and solidity. From this point of view, we have been discouraging the usage of OCCI since years.
Adds a parameters diplay plot for the
AlignPCLThresholdobject type, storing the "trigger-update" thresholds for theSiPixelAliPrompt Calibration Loop workflow.