Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Pythia8CUEP8M2T4Settings_cfi.py and CP1-5 cfi's. #21476

Merged
merged 2 commits into from Dec 22, 2017
Merged

Create Pythia8CUEP8M2T4Settings_cfi.py and CP1-5 cfi's. #21476

merged 2 commits into from Dec 22, 2017

Conversation

efeyazgan
Copy link
Contributor

backport the tune snippet CP0(=CUETP8M2T4) to 71X

@cmsbuild cmsbuild added this to the CMSSW_7_1_X milestone Nov 28, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @efeyazgan (Efe Yazgan) for CMSSW_7_1_X.

It involves the following packages:

Configuration/Generator

@cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@efeyazgan
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@perrozzi
Copy link
Contributor

perrozzi commented Nov 28, 2017 •
edited

maybe worth adding the CPi snippets as well

@perrozzi @efeyazgan
restore usual convention for PSet naming, fix CP1star to CP2 naming
d0528da 
Conflicts:
	Configuration/Generator/python/MCTunes2017/PythiaCP1Settings_cfi.py
	Configuration/Generator/python/MCTunes2017/PythiaCP2Settings_cfi.py
	Configuration/Generator/python/MCTunes2017/PythiaCP3Settings_cfi.py
	Configuration/Generator/python/MCTunes2017/PythiaCP4Settings_cfi.py
	Configuration/Generator/python/MCTunes2017/PythiaCP5Settings_cfi.py
@cmsbuild
Copy link
Contributor

Pull request #21476 was updated. @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please check and sign again.

@efeyazgan
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24726/console Started: 2017/11/28 19:01

@cmsbuild
Copy link
Contributor

+1
Tested at: d0528da
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21476/24726/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
421986b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21476/24726/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21476/24726/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21476/24726/summary.html

There are some workflows for which there are errors in the baseline:
1003.0 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 682535
  • DQMHistoTests: Total failures: 3316
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 678845
  • DQMHistoTests: Total skipped: 374
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 43 log files, 4 edm output root files, 11 DQM output files

@efeyazgan
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@perrozzi
Copy link
Contributor

(can change the PR name to reflect the enlarged scope)

@efeyazgan efeyazgan changed the title Create Pythia8CUEP8M2T4Settings_cfi.py Create Pythia8CUEP8M2T4Settings_cfi.py and CP1-5 cfi's. Nov 29, 2017
@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit da674c4 into cms-sw:CMSSW_7_1_X Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed generators-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@efeyazgan @cmsbuild @perrozzi @davidlange6