EventProcessor refactoring #21488
EventProcessor refactoring #21488
Conversation
mutable lambdas have non-const operator() which prohibits passing iAction as a const reference.
Changed the function handleNextEventForStreamAsync to take as argument a WaitingTaskHolder instead of a bare pointer. This simplifies the ownership logic. In addition, moved the construction of 'recursionTask' to be within the lambda which reads from the source since that is the only place it is needed.
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Concurrency @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
|
+1 |
Changed EventProcessor::handleNextEventForStreamAsync to take a WaitingTaskHolder instead of a
bare task pointer. This helps clean up the ownership issues and lays the ground work for better concurrency.