Actually cindelu CSCDMBHeader.h in CSCDMBTrailer2005/2013.h #21507
Conversation
We require the definition of this class in this piece of code:
```C++
bits.dmb_id = dmbHeader.dmbID();
^
```
So we actually have to include the header to make this file
parsable on its own.
|
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: EventFilter/CSCRawToDigi @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
merge |
Teemperor
deleted the
ActuallyCindeluCscdmbheaderhInCscdmbtrailer20052013h
branch
Teemperor
restored the
ActuallyCindeluCscdmbheaderhInCscdmbtrailer20052013h
branch
We require the definition of this class in this piece of code:
bits.dmb_id = dmbHeader.dmbID(); ^So we actually have to include the header to make this file
parsable on its own.