Added include for SiStripApvGain to SiStripGainsPCLHarvester.h #21525
Conversation
We reference SiStripApvGain but in this header, so we also need to include the associated header to make this file parsable on its own.
|
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: CalibTracker/SiStripChannelGain @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
merge |
Teemperor
restored the
IncludeSistripapvgainSistripgainspclharvesterh
branch
We reference SiStripApvGain but in this header, so we also
need to include the associated header to make this file
parsable on its own.