Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes for root6 relvals #2153

Merged
merged 2 commits into from Jan 23, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jan 23, 2014

Two more fixes in conditions code for bugs causing all relvals in ROOT6 to throw fatal exceptions.

  1. Reflex::CollFuncTable no longer exists in ROOT6. Use ROOT::TCollectionProxyInfo instead where applicable.
  2. The conditions code sometimes needs to retrieve the name of a typedef itself rather than the name of the underlying type. Add support for this in edm::TypeWithDict, and use it where needed.

NOTE: With these fixes, the relvals still fail later in the tests. The failure next encountered is a segfault, which now needs to be fixed. Do not reject this pull request because it results in the relvals segfaulting. The bug causing the segfaults was already there, but was hidden due to fatal exceptions arising earlier in the tests.

NOTE2: The change in STLContainerStreamer.cc is much less than it appears. The file was in DOS format.
I stripped the trailing carriage returns and trailing spaces. git diff -b shows the real difference.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_1_ROOT6_X.

More fixes for root6 relvals

It involves the following packages:

CondCore/ORA
FWCore/Utilities

@ggovi, @cmsbuild, @apfeiffer1, @Degano, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

davidlt added a commit that referenced this pull request Jan 23, 2014
@davidlt davidlt merged commit 2224b97 into cms-sw:CMSSW_7_1_ROOT6_X Jan 23, 2014
@wmtan wmtan deleted the MoreFixesForROOT6relvals branch January 23, 2014 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants