Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace boost::array with std::array #21543

Merged
merged 1 commit into from Dec 18, 2017
Merged

Replace boost::array with std::array #21543

merged 1 commit into from Dec 18, 2017

Conversation

Teemperor
Copy link
Contributor

@Teemperor Teemperor commented Nov 30, 2017 •
edited

No description provided.

@Teemperor
Copy link
Contributor Author

Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile.

@cmsbuild cmsbuild added this to the CMSSW_10_0_X milestone Nov 30, 2017
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21543/2304

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

CondFormats/HcalObjects

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@ghellwig
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 30, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24880/console Started: 2017/12/01 05:50

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2017

+1
Tested at: ae3a9e9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21543/24880/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9b38965
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21543/24880/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21543/24880/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2017

Comparison job queued.

@ghellwig
Copy link

ghellwig commented Dec 1, 2017

@Teemperor I know that this is not the scope of this PR, but couldn't we use this opportunity to migrate the boost::array to std::array to drop the boost dependency? Or is there some algorithm used that requires it to be boost::array?

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21543/24880/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2715851
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2715674
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.759999999922 KiB( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@ghellwig
Copy link

ghellwig commented Dec 5, 2017

@Teemperor ping

@Teemperor Teemperor force-pushed the IncludesBoostArrayHcalitemarraycollbyidh branch from ae3a9e9 to c4e6f74 Compare December 7, 2017 07:59
@ghellwig
Copy link

+1
provided jenkins agrees

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21543/2551

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25056/console Started: 2017/12/12 17:40

@cmsbuild
Copy link
Contributor

Pull request #21543 was updated. @ggovi, @cmsbuild can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1
Tested at: 8f5f4b0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21543/25056/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ef598b6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21543/25056/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21543/25056/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21543/25056/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21543/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2835241
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2835062
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.07 KiB( 22 files compared)
  • Checked 113 log files, 9 edm output root files, 27 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Dec 15, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 4ad2f17 into cms-sw:master Dec 18, 2017
@ghellwig
Copy link

@Teemperor I believe, it would be good for the release notes, if you changed the title of this PR back to the original one.

@Teemperor Teemperor deleted the IncludesBoostArrayHcalitemarraycollbyidh branch December 19, 2017 08:47
@Teemperor Teemperor restored the IncludesBoostArrayHcalitemarraycollbyidh branch December 19, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved code-checks-approved comparison-available db-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Teemperor @cmsbuild @ghellwig @ggovi @davidlange6