Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing includes to EventHypothesisLooper.h #21551

Merged
merged 1 commit into from Dec 4, 2017

Conversation

Teemperor
Copy link
Contributor

We actually dereference a pointer to reco::Candidate in this header,
so we can't just include the Fwd.h header but need the full
Candidate header. We also need to include the EventHypothesis.h
because we reference EventHypothesis in this header. This patch
adds these includes to make this header parsable on its own.

We actually dereference a pointer to reco::Candidate in this header,
so we can't just include the Fwd.h header but need the full
Candidate header. We also need to include the EventHypothesis.h
because we reference EventHypothesis in this header. This patch
adds these includes to make this header parsable on its own.
@Teemperor
Copy link
Contributor Author

Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21551/2312

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

DataFormats/PatCandidates

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@gpetruc, @gouskos, @rovere, @cbernet this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Nov 30, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 30, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24873/console Started: 2017/12/01 04:43

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21551/24873/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2835085
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2834906
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.579999999813 KiB( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@slava77
Copy link
Contributor

slava77 commented Dec 3, 2017

+1

for #21551 ca6ada0

  • technical update to add include files
  • jenkins tests pass

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 773e10e into cms-sw:master Dec 4, 2017
@Teemperor Teemperor deleted the IncludesEventhypothesislooperh branch December 19, 2017 08:47
@Teemperor Teemperor restored the IncludesEventhypothesislooperh branch December 19, 2017 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants