New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing includes to EventHypothesisLooper.h #21551
Added missing includes to EventHypothesisLooper.h #21551
Conversation
We actually dereference a pointer to reco::Candidate in this header, so we can't just include the Fwd.h header but need the full Candidate header. We also need to include the EventHypothesis.h because we reference EventHypothesis in this header. This patch adds these includes to make this header parsable on its own.
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: DataFormats/PatCandidates @perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
merge |
We actually dereference a pointer to reco::Candidate in this header,
so we can't just include the Fwd.h header but need the full
Candidate header. We also need to include the EventHypothesis.h
because we reference EventHypothesis in this header. This patch
adds these includes to make this header parsable on its own.