Qualified make_shared in GaussianSumUtilities.icc

[Teemperor]

No description provided.

[Teemperor]

Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21552/2313

[cmsbuild]

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

TrackingTools/GsfTools

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24871/console Started: 2017/12/01 04:34

[cmsbuild]

+1
Tested at: 36753a8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21552/24871/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a2fb258
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21552/24871/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21552/24871/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21552/24871/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2835085
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2834906
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.909999999902 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[VinInn]

title does not match code change...

[perrotta]

+1

• Technical
• Jenkins tests pass
  . Indeed, title should rather be something like "Qualified make_shared in GaussianSumUtilities.icc"

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21552/2613

[cmsbuild]

Pull request #21552 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[perrotta]

@davidlange6 : maybe we don't need to waste resources and relaunch the tests, given that only the title got changed...

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25126/console Started: 2017/12/15 19:00

[cmsbuild]

+1
Tested at: 97da808
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21552/25126/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21552/25126/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21552/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 20 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2836825
• DQMHistoTests: Total failures: 1844
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2834803
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.19000000008 KiB( 23 files compared)
• Checked 113 log files, 9 edm output root files, 27 DQM output files

[perrotta]

+1

• Technical

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

merge