Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BoundarySurface.h compile #21557

Merged
merged 1 commit into from Dec 2, 2017

Conversation

Teemperor
Copy link
Contributor

This header references LocalPoitn, so we also need include the
related header. Also the virtual functions are now correctly
marked as virtual to make clang happy.

This header references LocalPoitn, so we also need include the
related header. Also the virtual functions are now correctly
marked as virtual to make clang happy.
@Teemperor
Copy link
Contributor Author

Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21557/2318

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

MagneticField/VolumeGeometry

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@namapane this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Nov 30, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 30, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24867/console Started: 2017/12/01 04:20

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21557/24867/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2835085
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2834906
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.12999999997 KiB( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Dec 1, 2017

+1

  • Techincal
  • Jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 6d7914b into cms-sw:master Dec 2, 2017
@Teemperor Teemperor deleted the MakeBoundarysurfacehCompile branch December 19, 2017 08:47
@Teemperor Teemperor restored the MakeBoundarysurfacehCompile branch December 19, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants