Remove CSCTriggerGeometry and CSCTriggerGeomManager

[dildick]

The class CSCTriggerGeometry is not thread-safe. Instead, one should use CSCGeometry. CSCTriggerNumbering has sufficient auxiliary functions to obtains a CSC's ring and chamber number. This PR removes the class CSCTriggerGeometry and CSCTriggerGeomManager and related calls from CMSSW.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21655/2472

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DQM/L1TMonitor
L1Trigger/CSCCommonTrigger
L1Trigger/CSCTrackFinder
L1Trigger/L1TMuonEndCap
RecoMET/METProducers

@perrotta, @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @slava77, @vanbesien can you please review it and eventually sign? Thanks.
@jdamgov, @TaiSakuma, @gouskos, @kreczko, @ahinzmann, @mmarionncern, @Martin-Grunewald, @jdolen, @nhanvtran, @gkasieczka, @thomreis, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: b51f729
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21655/24980/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2699c4c
51d7a9a
25216ac
91341b1
2299834
d4a6c2d
ea1babf
ca9bcdb
35901a5
d431fe1
0179dc5
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21655/24980/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21655/24980/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21655/24980/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21655/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 55 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2835085
• DQMHistoTests: Total failures: 227
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2834680
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.08999999997 KiB( 23 files compared)
• Checked 113 log files, 9 edm output root files, 27 DQM output files

[perrotta]

please test
(Several differences are reported in the jenkins outputs, but they likely come from the many other commits tested together with this one. Let retry launching the tests: up to now I see no pull requests merged on top of the latest CMSSW_10_0_X_2017-12-06-2300, therefore I hope this one will get tested independently)

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: b51f729
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21655/24984/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2699c4c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21655/24984/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21655/24984/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21655/24984/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21655/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2798638
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2798459
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.24000000001 KiB( 23 files compared)
• Checked 113 log files, 9 edm output root files, 27 DQM output files

[slava77]

+1

for #21655 b51f729

• technical cleanup from the reco perspective
• jenkins tests pass and comparisons with baseline show no differences

[dmitrijus]

+1

[dildick]

@rekovic could you sign please?

[davidlange6]

merge