[HCAL] Mahi for HBHE local reconstruction #21664
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @jaylawhorn (Jay Lawhorn) for master. It involves the following packages: HLTrigger/Configuration @perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
jaylawhorn
changed the title
|
Just would like to suggest cmsDriver command for activating MAHI in RECO |
| @@ -17,6 +17,13 @@ | |||
| # pset.minGoodStripCharge = cms.PSet(refToPSet_ = cms.string('HLTSiStripClusterChargeCutNone')) | |||
| # return process | |||
|
|
|||
| # Add mahi to HCAL local reconstruction | |||
| def customiseForXXXXX(process): | |||
There was a problem hiding this comment.
replace XXXX with 21664
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
Pull request #21664 was updated. @perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please check and sign again. |
|
On 12/8/17 5:16 AM, Salavat Abdullin wrote:
Just would like to suggest cmsDriver command for activating MAHI in RECO
(for possible mentioning in the header of this PR):
--customise-command 'process.hbheprereco.algorithm.useMahi =
cms.bool(True) \n'
Commenting on the value of the switch (IMHO, it should be False here).
I thought that the plan is to have it on by default
and only make validation with the baseline with MAHI disabled with a
switch available.
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21664 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbiIeTUxPLr3NEPOkRK87KeRF8Khpks5s-TaRgaJpZM4Q6-k7>.
|
| @@ -9,6 +9,35 @@ | |||
| // Phase 1 HBHE reco algorithm headers | |||
| #include "RecoLocalCalo/HcalRecAlgos/interface/SimpleHBHEPhase1Algo.h" | |||
|
|
|||
| static std::unique_ptr<DoMahiAlgo> | |||
| parseHBHEMahiDescription(const edm::ParameterSet& conf) | |||
There was a problem hiding this comment.
To follow the naming choice of previous methods (M0, M1, M2, M3), at this layer the text should say M4.
|
Slava, I thought the agreement is the other way around (deactivated by
default) + specially requeted RelVals (1-2) with activated MAHI ?
…On Fri, 8 Dec 2017, Slava Krutelyov wrote:
On 12/8/17 5:16 AM, Salavat Abdullin wrote:
> Just would like to suggest cmsDriver command for activating MAHI in RECO
> (for possible mentioning in the header of this PR):
> --customise-command 'process.hbheprereco.algorithm.useMahi =
> cms.bool(True) \n'
Commenting on the value of the switch (IMHO, it should be False here).
I thought that the plan is to have it on by default
and only make validation with the baseline with MAHI disabled with a
switch available.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#21664 (comment)>, or
> mute the thread
> <https://github.com/notifications/unsubscribe-auth/AEdcbiIeTUxPLr3NEPOkRK87KeRF8Khpks5s-TaRgaJpZM4Q6-k7>.
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.[AEx02tJd7mtrFbu71Puuiq0tpnPIm5i-ks5s-UPDgaJpZM4Q6-k7.gif]
|
|
On 12/8/17 6:23 AM, Salavat Abdullin wrote:
Slava, I thought the agreement is the other way around (deactivated by
default) + specially requeted RelVals (1-2) with activated MAHI ?
I don't think we have time to deploy in 10_0_X if we do it this way.
…
On Fri, 8 Dec 2017, Slava Krutelyov wrote:
> On 12/8/17 5:16 AM, Salavat Abdullin wrote:
> > Just would like to suggest cmsDriver command for activating MAHI in RECO
> > (for possible mentioning in the header of this PR):
> > --customise-command 'process.hbheprereco.algorithm.useMahi =
> > cms.bool(True) \n'
>
> Commenting on the value of the switch (IMHO, it should be False here).
>
> I thought that the plan is to have it on by default
> and only make validation with the baseline with MAHI disabled with a
> switch available.
|
|
OK, good point. I just thought we may need to take some precations...
…On Fri, 8 Dec 2017, Slava Krutelyov wrote:
On 12/8/17 6:23 AM, Salavat Abdullin wrote:
>
> Slava, I thought the agreement is the other way around (deactivated by
> default) + specially requeted RelVals (1-2) with activated MAHI ?
I don't think we have time to deploy in 10_0_X if we do it this way.
>
>
> On Fri, 8 Dec 2017, Slava Krutelyov wrote:
>
>> On 12/8/17 5:16 AM, Salavat Abdullin wrote:
>> > Just would like to suggest cmsDriver command for activating MAHI in RECO
>> > (for possible mentioning in the header of this PR):
>> > --customise-command 'process.hbheprereco.algorithm.useMahi =
>> > cms.bool(True) \n'
>>
>> Commenting on the value of the switch (IMHO, it should be False here).
>>
>> I thought that the plan is to have it on by default
>> and only make validation with the baseline with MAHI disabled with a
>> switch available.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.[AEx02g5fZH1A5j7hSFlmtjkLsgGgBOTIks5s-UnzgaJpZM4Q6-k7.gif]
|
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21664/2707 |
|
Pull request #21664 was updated. @perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 for #21664 b4ded0f
|
|
+1 |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
merge |
Mahi is an HBHE local reconstruction algorithm intended to (eventually) replace both Method 2 and Method 3.
Documentation can be found here:
2017-12-8-mahi.pdf
In this PR, Mahi is turned off by default. It can be activated in the offline reco chain here https://github.com/jaylawhorn/cmssw/blob/89ea053bb647663fc8ffc342ab2c69c80985de75/RecoLocalCalo/HcalRecProducers/python/HBHEPhase1Reconstructor_cfi.py#L77
and the offline decision is used at HLT here
https://github.com/jaylawhorn/cmssw/blob/89ea053bb647663fc8ffc342ab2c69c80985de75/HLTrigger/Configuration/python/customizeHLTforCMSSW.py#L24