Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "pixel tracking only" workflow to 2017 matrix, and it and "tracking only" workflow to 2018 matrix #21713

Merged
merged 3 commits into from Dec 19, 2017

Conversation

makortel
Copy link
Contributor

This PR adds a "pixel tracking only" workflow aiming to have a minimal step3 configuration for producing pixel tracks and vertices (+ their validation). Such a workflow is useful e.g. for future tracking R&D.

Tested in CMSSW_10_0_X_2017-12-13-2300, no changes expected in existing workflows.

@VinInn @felicepantaleo @fwyzard

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Configuration/PyReleaseValidation
Configuration/StandardSequences
Validation/Configuration
Validation/RecoTrack
Validation/RecoVertex

@perrotta, @prebello, @vazzolini, @kmaeshima, @davidlange6, @civanch, @mdhildreth, @fabozzi, @cmsbuild, @franzoni, @jfernan2, @kpedro88, @slava77, @GurpreetSinghChahal, @vanbesien, @dmitrijus can you please review it and eventually sign? Thanks.
@ghellwig, @swertz, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @wmtford, @ebrondol, @mtosi, @dgulhan, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test workflow 10024.5,10824.1,10824.5

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 14, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25091/console Started: 2017/12/14 17:12

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21713/25091/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21713/10024.5_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_pixelTrackingOnly_2017+HARVESTFull_pixelTrackingOnly_2017
  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21713/10824.1_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_trackingOnly_2017+HARVESTFull_trackingOnly_2017
  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21713/10824.5_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_pixelTrackingOnly_2017+HARVESTFull_pixelTrackingOnly_2017
  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21713/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2836825
  • DQMHistoTests: Total failures: 1109
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2835538
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.89000000013 KiB( 23 files compared)
  • Checked 113 log files, 9 edm output root files, 27 DQM output files

@perrotta
Copy link
Contributor

+1

  • The newly inserted workflows do run

@civanch
Copy link
Contributor

civanch commented Dec 18, 2017

+1

@fabozzi
Copy link
Contributor

fabozzi commented Dec 18, 2017

+1

@kpedro88
Copy link
Contributor

+1

@dmitrijus
Copy link
Contributor

+1

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 8f0fb1d into cms-sw:master Dec 19, 2017
@makortel makortel deleted the pixelTrackingOnlyWf branch February 12, 2018 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants