Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HGCAL trigger updates #21728

Merged
merged 89 commits into from Jan 27, 2018
Merged

HGCAL trigger updates #21728

merged 89 commits into from Jan 27, 2018

Conversation

jbsauvan
Copy link
Contributor

This PR adds the following changes for the HGCAL trigger:

  • Layer-by-layer calibration of the clusters
  • Cluster shape variables calculation
  • New 3D clustering algorithm (DBSCAN)
  • Disconnection of half the HGC-EE layers when creating trigger cells
  • Updates of the ntuples content

jbsauvan and others added 30 commits August 4, 2017 15:59
@jbsauvan
Merged hgc-tpg-devel-CMSSW_9_3_0_pre2 from repository PFCal-dev
0e6fef9
@jbsauvan
Increase TC nbits to 20
7701c3e
@jbsauvan
Merge pull request #132 from jbsauvan/increase-tc-saturation
dfec795 
Increase TC energy saturation
@jbsauvan
Merged hgc-tpg-devel-CMSSW_9_3_0_pre2 from repository PFCal-dev with …
a6b93d8 
…cms-merge-topic
@jbsauvan
Update relval test file for 930pre4
291432e
@jbsauvan
first try
d413a0b
@jbsauvan
simplify and clean HGCalShowerShape
e9c3287
@jbsauvan
First working version for Electron ID
392d586
@jbsauvan
dont use 2D shower shape for the moment
69915df
@jbsauvan
new structure for HGCalShowerShape
c4c7992
@jbsauvan
clean version
37463b2
@jbsauvan
Adress PR comments
548c709
@jbsauvan
Adress PR comments Part II
8dd2512
@jbsauvan
Adress PR comments Part III
c4e1890
@jbsauvan
Address PR comments Part IV
e0d092a
@jbsauvan
Remove useless comments
b89fdcd
@jbsauvan
Revert empty changes
342a410
@jbsauvan
Merge pull request #137 from jbsauvan/ElectronID
f1d2669 
Electron ID variables
@osahin
The DBSCAN algorithm is implemented for the 3D clusters
d8dc0d5
@osahin
fixing minor bugs and correcting the parameters
ad183c8
@osahin
Minor fixes (see comments to the PR)
f803e7a
@osahin
Minor fixes (see comments to the PR)
974eef1
@osahin
tabs are replaced with spaces
4e5c729
@osahin
tabs are replaced with spaces
6e1994e
@osahin
tabs are replaced with spaces
b5cb13b
@jbsauvan
Merge pull request #139 from osahin/DBSCAN-3DCluster
7947a82 
DBSCAN 3D cluster algorithm
@jbsauvan
Merged hgc-tpg-devel-CMSSW_9_3_0_pre4 from repository PFCal-dev with …
b9be92d 
…cms-merge-topic
@osahin
DBSCAN with 1D sorting is implemented. The sorted-DBSCAN performs up …
c61cbbc 
…to 20 times faster than the unsorted version
@osahin
OutOfBound excaption for the clustersPtrs is included
e0dfea5
@osahin
exceptions for the clusterPtrs' range are included in the findNeighbo…
3131221 
…r method
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 15, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25456/console Started: 2018/01/15 18:35

@cmsbuild
Copy link
Contributor

+1
Tested at: f1f0db6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21728/25456/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
35bb0f6
b23167d
118cd2e
edb5262
1db2895
481009f
fa10501
23ba449
a0a50f5
ed87015
332e614
100fe46
7d67ea3
2cd2cfb
b2ccbbe
5e8c913
b9be92d
7947a82
f1d2669
a6b93d8
dfec795
0e6fef9
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21728/25456/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21728/25456/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21728/25456/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21728/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2467599
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2467429
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.10999999971 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@jbsauvan
Copy link
Contributor Author

Hello,
Are the updates satisfactory? Is there any other issue or comment?
Thanks!

@kpedro88
Copy link
Contributor

+1

@jbsauvan
Copy link
Contributor Author

Hello,
Is there anything that prevents this PR to be merged?

@kpedro88
Copy link
Contributor

@rekovic please sign

@smuzaffar smuzaffar modified the milestones: CMSSW_10_0_X, CMSSW_10_1_X Jan 24, 2018
@rekovic
Copy link
Contributor

rekovic commented Jan 24, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d8e1b07 into cms-sw:master Jan 27, 2018
@jbsauvan jbsauvan mentioned this pull request Feb 22, 2018
Merged
@jbsauvan jbsauvan mentioned this pull request Nov 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osahin osahin osahin left review comments

@kpedro88 kpedro88 kpedro88 left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed l1-approved orp-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_10_1_X
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@jbsauvan @cmsbuild @kpedro88 @rekovic @fabiocos @osahin @smuzaffar @tstreble @mastrolorenzo