Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT DQM: use global, concurrent monitor elements #21738

Merged
merged 9 commits into from Jan 14, 2018

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Dec 17, 2017

Update the Services and DQMEDAnalyzers in HLTrigger/Timer to make use the new concurrent-safe booking and monitor elements.

This PR builds on top of, and includes, #21652 .

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 17, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

DQM/HLTEvF
DQMServices/Components
DQMServices/Core
DQMServices/FileIO
HLTrigger/Timer

@cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @Martin-Grunewald, @silviodonato, @jfernan2, @fwyzard, @vanbesien can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mtosi, @barvic this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 17, 2017

+1

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 17, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

-1

Tested at: 6b5bbd8

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21738/25352/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.731 step1

DAS Error
136.7611 step1
DAS Error
136.788 step1
DAS Error
140.53 step1
DAS Error

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@prebello
Copy link
Contributor

@fabiocos
failed with DAS ERROR because these wfs are still stuck.
Please see JIRA 1988

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25401/console Started: 2018/01/12 11:03

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21738/25401/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21738/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2467710
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2467540
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.899999999951 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7812e59 into cms-sw:master Jan 14, 2018
@fwyzard fwyzard deleted the HLTTimer_updates_100x branch January 17, 2018 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants