Make separate L1T autoDQM sequences for efficiency measurements #21754
Conversation
…offline_config_changes
…because of missing emulated hacl TPs.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21754/2709 |
|
A new Pull Request was created by @thomreis (Thomas Reis) for master. It involves the following packages: DQMOffline/Configuration @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 0617398 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
…o avoid crash legacy workflow 1001.0.
|
Pull request #21754 was updated. @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please check and sign again. |
|
please test The l1TriggerDqmOffline sequence was put back in the DQMOfflineCommonSiStripZeroBias sequence to avoid a crash with missing hcal TP emulation in a module named tpTask. |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@davidlange6 can this be reviewed/merged please? |
|
+1 |
The L1T offline DQM efficiency measurements for objects do not need to run on every dataset.
L1T muon, tau, MET, and jet efficiencies can use the singleMuon dataset and L1T EGamma efficiencies are calculated using the singleElectron dataset.
This PR creates new DQM sequences for L1T in autoDQM.py that contain only the efficiency modules. For running at the T0 the DQM sequences need to be added to the dmwm/T0/etc/ProdOfflineConfiguration.py configuration for the singleMuon dataset (https://github.com/dmwm/T0/blob/master/etc/ProdOfflineConfiguration.py#L599) and the singleElectron dataset (https://github.com/dmwm/T0/blob/master/etc/ProdOfflineConfiguration.py#L584).
For RelVal some changes would be needed as well (probably somewhere in https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_steps.py#L1566) to run the DQM efficiency calculation only for some MC and data samples.