Fix creation of 2D efficiency histograms in TagProbeFitter

[tmadlener]

Currently makeEfficiencyPlot2D is called with "allCats1D" as catName argument. This leads to empty 2D efficiency histograms, since the passed catIndex and the one obtained from the passed RooDataSet never match (TagProbFitter.cc:L815).
Since the RooMultiCategory used as column in the RooDataSet myEff is created with the name "allCats2D", this issue can be fixed by calling makeEfficiencyPlot2D with the appropriate argument.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21762/2725

[cmsbuild]

A new Pull Request was created by @tmadlener (Thomas Madlener) for master.

It involves the following packages:

PhysicsTools/TagAndProbe

@cmsbuild, @monttj can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25283/console Started: 2017/12/27 14:33

[cmsbuild]

+1
Tested at: ea939d6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21762/25283/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21762/25283/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21762/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2773742
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2773572
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.15999999995 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[davidlange6]

merge