TTStub and TTCluster class porting to CMSSW 10 #21765

sviret · 2017-12-21T15:33:49Z

This branch contains significant updates of the TTStub building algorithm, and a TTCluster association update:

FE inefficiencies: if this option is turned on (default is off), the MPA/CBC and CIC inefficiencies are accounted for based on the event sequence over which stubs are reconstructed. CIC inefficiency is only partially accounted, MPA and CBC are exact.
Hardware bend degradation: bend is encoded on a limited number of bits. Therefore for given stub window tuning all the values cannot be encoded independently and they must be grouped. This process is now done during the Stub building, and the degraded bend can be obtained using the getHardwareBend() method, which is added to the TTStub class. Of course nominal bend is still accessible.
Full parallax correction: within the FE asics, parallax is corrected in half-strips units. However, the exact parallax value can always be retrieved at the backend using the stub position and module radius, and can subsequently be used to improve the bend resolution. This parameter is therefore computed during stub building, and can be retrieved via the method getRealTriggerOffset()
New stub window tuning: stub are built using the new tuning optimized for PU200 events. The default tuning is PU200 TIGHT. For stub tuning documentation, information is available here: https://www.dropbox.com/s/sc1ifhfbcv5pts3/Stub%20windows%20tuning-%20a%20tutorial.pdf?dl=0
Updated TTCluster association scheme:

/// OLD ASSOCIATION SCHEME
/// MC truth
/// Table to define Genuine, Combinatoric and Unknown
///
/// N = number of NULL TP pointers
/// D = number of GOOD TP pointers different from each other
///
/// N / D--> | 0 | 1 | >1
/// ----------------------
/// 0        | U | G | C
/// ----------------------
/// >0       | U | C | C

is replaced by his

/// MC truth
/// Table to define Genuine, Combinatoric and Unknown
///
/// N = number of NULL TP pointers
/// D = number of GOOD TP pointers different from each other
///
/// N / D--> | 0 | 1 | >1 (with 1 TP w/more than 99% of total cluster pT) | >1 (other)
/// -------------------------------------------------------------------
/// 0        | U | G | G                                                  | C
/// -------------------------------------------------------------------
/// >0       | U | G | G                                                  | C
///

With this new association scheme, a cluster made from more than 1 digis, with one digi associated to a low-pt secondary and the other one associated to the primary will be flagged as genuine and associated to the primary TP. Was flagged as combinatoric with the previous association.

IMPORTANT NOTE: This PR does not include any modification of the TTTrack class, as Track Trigger algorithm using it are still in development phase within CMSSW

Dumb fix...

cmsbuild · 2017-12-21T15:34:13Z

@sviret, CMSSW_10_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

cmsbuild · 2017-12-21T15:34:47Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-12-21T15:36:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21765/2729

cmsbuild · 2017-12-21T15:36:56Z

A new Pull Request was created by @sviret (Seb Viret) for master.

It involves the following packages:

DataFormats/L1TrackTrigger
L1Trigger/TrackTrigger
SimTracker/TrackTriggerAssociation

@cmsbuild, @civanch, @mdhildreth, @nsmith-, @rekovic, @kpedro88, @thomreis can you please review it and eventually sign? Thanks.
@kreczko, @makortel, @sdevissc, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2017-12-21T15:46:41Z

please test

cmsbuild · 2017-12-21T15:47:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25248/console Started: 2017/12/21 20:26

kpedro88 · 2017-12-21T16:09:30Z

DataFormats/L1TrackTrigger/interface/TTStub.h

@@ -80,6 +88,8 @@ TTStub< T >::TTStub()
  theDetId = 0;
  theDisplacement = 999999;
  theOffset = 0;
+  theRealOffset = 0;
+  theHardwareBend = 999999;


Since the "999999" value is used in multiple places, it should be a const member of the class (e.g. defaultHardwareBend)

kpedro88 · 2017-12-21T16:09:36Z

L1Trigger/TrackTrigger/plugins/TTStubBuilder.cc

+
+  // Loop over all the tracker elements
+
+  for (auto gd=theTrackerGeom->dets().begin(); gd != theTrackerGeom->dets().end(); gd++)


range-based loop

kpedro88 · 2017-12-21T16:11:17Z

L1Trigger/TrackTrigger/plugins/TTStubBuilder.cc

+    }
+    else if (detid.subdetId()==StripSubdetector::TID)
+    {
+      if (tTopo->tidWheel(detid)<=2 && tTopo->tidRing(detid)<=4) is10G_PS = true;


Can these magic numbers be obtained from some geometry/topology class? Otherwise, should be made into descriptive constants

Done, numbers have been passed as joboptions

kpedro88 · 2017-12-21T16:15:55Z

L1Trigger/TrackTrigger/plugins/TTStubBuilder.cc

-    const PixelGeomDetUnit* pix0 = dynamic_cast< const PixelGeomDetUnit* >( det0 );
-    const PixelTopology* top0 = dynamic_cast< const PixelTopology* >( &(pix0->specificTopology()) );
-    const int chipSize = 2 * top0->rowsperroc(); /// Need to find ASIC size in half-strip units
+    //const GeomDetUnit* det0 = theTrackerGeom->idToDetUnit( lowerDetid );


delete commented-out code

kpedro88 · 2017-12-21T16:17:10Z

L1Trigger/TrackTrigger/plugins/TTStubBuilder.cc

-          if ( moduleStubs.find( chip ) == moduleStubs.end() ) /// Already a stub for this ASIC?
+          MeasurementPoint mp0 = tempTTStub.getClusterRef(0)->findAverageLocalCoordinates();
+          int seg       = static_cast<int>(mp0.y());
+	  if (isPS) seg = seg/16;


use consistent indentation

Perhaps done...

kpedro88 · 2017-12-21T16:43:47Z

L1Trigger/TrackTrigger/src/TTStubAlgorithm_official.cc

+      throw cms::Exception("DegradeBend: logic error with odd numbers");
+    }
+
+    for (unsigned int i = 0; i < numSmallGroups/2; i++) groups.push_back(inSmallGroup);


reserve() again

kpedro88 · 2017-12-21T16:45:00Z

SimTracker/TrackTriggerAssociation/interface/TTClusterAssociationMap.h

@@ -146,6 +163,12 @@ bool TTClusterAssociationMap< T >::isGenuine( edm::Ref< edmNew::DetSetVector< TT
  unsigned int goodDifferentTPs = 0;
  std::vector< const TrackingParticle* > tpAddressVector;

+  std::vector<float> tp_mom;
+
+  tp_mom.clear();


no need to clear vector right after creating it...

kpedro88 · 2017-12-21T16:45:59Z

SimTracker/TrackTriggerAssociation/interface/TTClusterAssociationMap.h

+
+  if (tp_tot==0) return false;
+
+  for ( unsigned int itp = 0; itp < theseTrackingParticles.size(); itp++ )


range-based loop w/ const auto&

kpedro88 · 2017-12-21T16:46:15Z

SimTracker/TrackTriggerAssociation/interface/TTClusterAssociationMap.h


  /// Count how many different TrackingParticle there are
  std::sort( tpAddressVector.begin(), tpAddressVector.end() );
  tpAddressVector.erase( std::unique( tpAddressVector.begin(), tpAddressVector.end() ), tpAddressVector.end() );
  goodDifferentTPs = tpAddressVector.size();
+  /*


delete commented-out code

kpedro88 · 2017-12-21T16:46:38Z

SimTracker/TrackTriggerAssociation/interface/TTClusterAssociationMap.h

  /// GENUINE means no NULLs and only one good TP
-  return ( nullTPs == 0 && goodDifferentTPs == 1 );
+  //return ( nullTPs == 0 && goodDifferentTPs == 1 );


delete commented-out code

cmsbuild · 2017-12-21T21:40:37Z

-1

Tested at: 4d1c103

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21765/25248/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017/step2_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017.log

cmsbuild · 2017-12-21T21:40:39Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

sviret · 2018-01-26T14:04:39Z

Not sure that this error is related to the PR itself.

boudoul · 2018-01-26T14:20:12Z

There are not, if you look at the log, this is an error when trying to open a file ... Seems other PR are affected too

fabiocos · 2018-01-27T17:21:06Z

please test

cmsbuild · 2018-01-27T17:21:23Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25681/console Started: 2018/01/27 19:09

cmsbuild · 2018-01-27T20:41:25Z

+1
Tested at: d70ef59
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21765/25681/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6ff2dda
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21765/25681/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21765/25681/git-merge-result

cmsbuild · 2018-01-27T20:41:28Z

Comparison job queued.

cmsbuild · 2018-01-27T22:03:19Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21765/25681/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21765/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2464350
DQMHistoTests: Total failures: 148
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2464033
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.970000000052 KiB( 22 files compared)
Checked 110 log files, 9 edm output root files, 26 DQM output files

fabiocos · 2018-01-28T11:37:19Z

+1

rekovic · 2018-02-12T17:16:08Z

@sviret, @boudoul
I guess we need to backport this to 93x if we want PU200 tuned TTStubs and correct TrackTriggerAssociatorClustersStubs for the Tracker geometry T5 used in CMSSW_9_3_5.
If that is correct, would it be possible to have the backport?
(attn @kpedro88)

kpedro88 · 2018-02-12T17:25:11Z

@rekovic since this PR only affects trigger, it should be acceptable to backport it to 9_3_X and make a 9_3_6 release for trigger study production.

rekovic · 2018-02-12T17:51:15Z

@kpedro88 Thx.

kpedro88 · 2018-02-21T14:37:44Z

@rekovic is this backport going to happen?

rekovic · 2018-02-23T14:26:48Z

@kpedro88
Was waiting for Tracking, but here it is.

Seb and others added 7 commits November 22, 2017 14:39

Porting Stub building code into CMSSW_10

fa2275f

Add bend degradation capability

f6c9130

Update TTStubAlgorithm_official.cc

f48f408

Dumb fix...

Update SLHC_MBIAS_TkOnly.py

ba3b836

Update SLHC_PGUN_TkOnly.py

004a378

Update SLHC_PU_TkOnly.py

63dd5e0

Change the default stub windows tuning by PU200 tight

4d1c103

cmsbuild changed the base branch from CMSSW_10_0_X to master December 21, 2017 15:34

cmsbuild added this to the CMSSW_10_0_X milestone Dec 21, 2017

cmsbuild added code-checks-pending comparison-pending l1-pending orp-pending pending-signatures simulation-pending tests-pending upgrade-pending labels Dec 21, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 21, 2017

cmsbuild added tests-started and removed tests-pending labels Dec 21, 2017

kpedro88 reviewed Dec 21, 2017

View reviewed changes

cmsbuild added comparison-notrun tests-rejected and removed tests-started labels Jan 26, 2018

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Jan 27, 2018

cmsbuild added tests-started and removed tests-pending labels Jan 27, 2018

cmsbuild added tests-approved and removed tests-started labels Jan 27, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jan 27, 2018

cmsbuild added orp-approved and removed orp-pending labels Jan 28, 2018

cmsbuild merged commit 46be6bb into cms-sw:master Jan 28, 2018

rekovic mentioned this pull request Feb 23, 2018

Pr93x TTStub Bulider & TTCluster Association from 10_1_x #22317

Merged


		// Loop over all the tracker elements

		for (auto gd=theTrackerGeom->dets().begin(); gd != theTrackerGeom->dets().end(); gd++)


		if (tp_tot==0) return false;

		for ( unsigned int itp = 0; itp < theseTrackingParticles.size(); itp++ )

TTStub and TTCluster class porting to CMSSW 10 #21765

TTStub and TTCluster class porting to CMSSW 10 #21765

Conversation

sviret commented Dec 21, 2017

cmsbuild commented Dec 21, 2017

cmsbuild commented Dec 21, 2017

cmsbuild commented Dec 21, 2017

cmsbuild commented Dec 21, 2017

kpedro88 commented Dec 21, 2017

cmsbuild commented Dec 21, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Dec 21, 2017

cmsbuild commented Dec 21, 2017

sviret commented Jan 26, 2018

boudoul commented Jan 26, 2018

fabiocos commented Jan 27, 2018

cmsbuild commented Jan 27, 2018 • edited Loading

cmsbuild commented Jan 27, 2018

cmsbuild commented Jan 27, 2018

cmsbuild commented Jan 27, 2018

fabiocos commented Jan 28, 2018

rekovic commented Feb 12, 2018

kpedro88 commented Feb 12, 2018

rekovic commented Feb 12, 2018

kpedro88 commented Feb 21, 2018

rekovic commented Feb 23, 2018

cmsbuild commented Dec 21, 2017 •

edited

Loading

cmsbuild commented Jan 27, 2018 •

edited

Loading