Revert making a copy of RefCore in RefVector calls #21772
Conversation
The clang check change made previously incorrectly converted a needed copy to just be a const ref. This ultimately lead to a threading race-condition when that code was called.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21772/2736 |
|
please test |
|
+1 |
cmsbuild
added
code-checks-approved
core-approved
fully-signed
and removed
code-checks-pending
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: DataFormats/Common @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
once it gets through the jenkins tests, please also submit a backport to 94X. |
|
I was already making the backport. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21772/2745 |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
code-checks-approved
core-approved
fully-signed
and removed
code-checks-pending
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@davidlange6 done |
|
merge |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
The clang check change made previously incorrectly converted a needed copy to just be a const ref. This ultimately lead to a threading race-condition when that code was called.