Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inputLabel of new DTuROS unpacker #21798

Merged
merged 1 commit into from Jan 4, 2018

Conversation

Martin-Grunewald
Copy link
Contributor

Fix inputLabel of new DTuROS unpacker
c.f. #21474

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2018

The code-checks are being triggered in jenkins.

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25300/console Started: 2018/01/03 07:27

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2018

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

EventFilter/DTRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21798/25300/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21798/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2775243
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2775073
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.639999999818 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@Martin-Grunewald
Copy link
Contributor Author

type bug-fix

@Martin-Grunewald
Copy link
Contributor Author

Fixes the problem in TSG tests discussed in #21474

@perrotta
Copy link
Contributor

perrotta commented Jan 3, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit b132537 into cms-sw:master Jan 4, 2018
@Martin-Grunewald Martin-Grunewald deleted the FixInputLabel branch April 27, 2018 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants