Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete timing modules #21825

Merged
merged 2 commits into from Jan 12, 2018

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jan 11, 2018

No description provided.

@fwyzard fwyzard force-pushed the remove_obsolete_timer_modules branch from cbbc937 to ad7553f Compare January 11, 2018 10:26
@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 11, 2018

@cmsbuild, please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 11, 2018

git-cms-checkdeps does not find any dependencies; is there any way to check that these modules are not actually used anywhere ?

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 11, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25368/console Started: 2018/01/11 11:37

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HLTrigger/Timer

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fwyzard fwyzard force-pushed the remove_obsolete_timer_modules branch from ad7553f to eeaaa7e Compare January 11, 2018 10:40
@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 11, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1

Tested at: ad7553f

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21825/25368/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-10-2300/src/Utilities/StaticAnalyzers/src/murmur.c 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-10-2300/src/HLTrigger/Timer/plugins/FastTimerServiceClient.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-10-2300/src/HLTrigger/Timer/plugins/ThroughputService.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-10-2300/src/HLTrigger/Timer/plugins/plugins.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-10-2300/src/HLTrigger/Timer/plugins/plugins.cc:3:0:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-10-2300/poison/HLTrigger/Timer/interface/TimerService.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^~~~~
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-10-2300/src/HLTrigger/Timer/plugins/plugins.cc:4:0:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-10-2300/poison/HLTrigger/Timer/interface/Timer.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.


@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 11, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25371/console Started: 2018/01/11 11:43

@cmsbuild
Copy link
Contributor

Pull request #21825 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21825/25371/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21825/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2774843
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2774673
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.19000000002 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6819961 into cms-sw:master Jan 12, 2018
@fwyzard fwyzard deleted the remove_obsolete_timer_modules branch January 17, 2018 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants