New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete timing modules #21825
Remove obsolete timing modules #21825
Conversation
cbbc937
to
ad7553f
Compare
@cmsbuild, please test |
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21825/2834 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: HLTrigger/Timer @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
ad7553f
to
eeaaa7e
Compare
@cmsbuild, please test |
The code-checks are being triggered in jenkins. |
-1 Tested at: ad7553f You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-10-2300/src/Utilities/StaticAnalyzers/src/murmur.c >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-10-2300/src/HLTrigger/Timer/plugins/FastTimerServiceClient.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-10-2300/src/HLTrigger/Timer/plugins/ThroughputService.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-10-2300/src/HLTrigger/Timer/plugins/plugins.cc In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-10-2300/src/HLTrigger/Timer/plugins/plugins.cc:3:0: /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-10-2300/poison/HLTrigger/Timer/interface/TimerService.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. ^~~~~ In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-10-2300/src/HLTrigger/Timer/plugins/plugins.cc:4:0: /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-10-2300/poison/HLTrigger/Timer/interface/Timer.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21825/2837 |
The tests are being triggered in jenkins. |
Pull request #21825 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
No description provided.