L1T DQM offline muon efficiency upgrades

[thomreis]

Upgrades for the L1T offline DQM code to produce efficiency and resolution plots.

• Separate efficiency plots for all TF regions
• pt cut + quality cut combinations configurable from cfg file
• Add efficiency vs. number of vertex plots
• Add q/pT resolution histograms
• Use L1T muon coordinates at the vertex
• Use DQMGenericClient to divide numerator and denominator histograms
• Use only L1T muons from BX 0

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21835/2853

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

DQMOffline/L1Trigger

@cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please review it and eventually sign? Thanks.
@kreczko, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[thomreis]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25402/console Started: 2018/01/12 11:05

[cmsbuild]

+1
Tested at: c4f856f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21835/25402/summary.html

[cmsbuild]

Comparison job queued.

[thomreis]

+1

I guess the DQMEDAnalyzer PR #21871 was expected to create some conflicts when merged.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21835/3096

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25721/console Started: 2018/01/29 11:11

[cmsbuild]

Pull request #21835 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

[cmsbuild]

+1
Tested at: dac9868
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21835/25721/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dac9868
6db25f1
e2f007e
ae20af0
44a08f1
31d9d2e
35ff8bf
9773c53
24db03f
e2fda46
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21835/25721/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21835/25721/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21835/25721/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21835/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2458206
• DQMHistoTests: Total failures: 253
• DQMHistoTests: Total nulls: 10
• DQMHistoTests: Total successes: 2457774
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 322.59 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[thomreis]

@dmitrijus @jfernan2 can you please sign this one again?

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[thomreis]

@fabiocos @davidlange6 all conflicts have been resolved and tests are OK. Can this be merged please?

[fabiocos]

+1