New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A fix for nullptr dereference in SiStripMonitorCluster #21866
Conversation
please test workflow 140.52, 140.54 |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21866/2905 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @dmitrijus (Dmitrijus) for master. It involves the following packages: DQM/SiStripMonitorCluster @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Tested at: 6d4a6e3 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build ClangBuild
I found an error when building: >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/Utilities/StaticAnalyzers/src/FunctionDumper.cpp >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/Utilities/StaticAnalyzers/src/ArgSizeChecker.cpp >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/Utilities/StaticAnalyzers/src/ConstCastChecker.cpp >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/Utilities/StaticAnalyzers/src/ConstCastAwayChecker.cpp In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/GeneratorInterface/Herwig7Interface/src/HerwigUIProvider.cc:6:0: /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/GeneratorInterface/Herwig7Interface/interface/HerwigUIProvider.h:7:33: fatal error: Herwig/API/HerwigUI.h: No such file or directory #include ^ compilation terminated. >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/Utilities/StaticAnalyzers/src/edmChecker.cpp gmake: *** [tmp/slc6_amd64_gcc630/src/GeneratorInterface/Herwig7Interface/src/GeneratorInterfaceHerwig7Interface/HerwigUIProvider.o] Error 1
I found a compilation error while trying to compile with clang: >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/DQM/SiStripMonitorCluster/src/SiStripMonitorFilter.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/DQM/SiStripMonitorCluster/src/SealModules.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/DQM/SiStripMonitorCluster/src/SiStripMonitorHLT.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/DQM/SiStripMonitorCluster/src/MonitorLTC.cc In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/GeneratorInterface/Herwig7Interface/src/HerwigUIProvider.cc:6: /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/GeneratorInterface/Herwig7Interface/interface/HerwigUIProvider.h:7:10: fatal error: 'Herwig/API/HerwigUI.h' file not found #include ^~~~~~~~~~~~~~~~~~~~~~~ /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/GeneratorInterface/Herwig7Interface/src/Herwig7Interface.cc:24:10: fatal error: 'Herwig/API/HerwigAPI.h' file not found #include ^~~~~~~~~~~~~~~~~~~~~~~~ The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
please test workflow 140.52, 140.54 with cms-sw/cmsdist#3642 |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
@dmitrijus This PR seems to fix the problem, unfortunately the blank space changes makes difficult to compare with the committed code. The dependence on externals is just fake (the new Herwig was pending for the 2300 build). If you are satisfied please sign it, I would like to add it at 1100. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@dmitrijus I see, thanks. I merge it. |
+1 |
Fixes #21858