Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A fix for nullptr dereference in SiStripMonitorCluster #21866

Merged
merged 2 commits into from Jan 17, 2018

Conversation

dmitrijus
Copy link
Contributor

Fixes #21858

@dmitrijus
Copy link
Contributor Author

please test workflow 140.52, 140.54

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 16, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25475/console Started: 2018/01/16 18:25

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for master.

It involves the following packages:

DQM/SiStripMonitorCluster

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: 6d4a6e3

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
52ba2cf
ad0debb
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21866/25475/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21866/25475/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21866/25475/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

  • Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/Utilities/StaticAnalyzers/src/FunctionDumper.cpp 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/Utilities/StaticAnalyzers/src/ArgSizeChecker.cpp 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/Utilities/StaticAnalyzers/src/ConstCastChecker.cpp 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/Utilities/StaticAnalyzers/src/ConstCastAwayChecker.cpp 
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/GeneratorInterface/Herwig7Interface/src/HerwigUIProvider.cc:6:0:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/GeneratorInterface/Herwig7Interface/interface/HerwigUIProvider.h:7:33: fatal error: Herwig/API/HerwigUI.h: No such file or directory
 #include 
                                 ^
compilation terminated.
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/Utilities/StaticAnalyzers/src/edmChecker.cpp 
gmake: *** [tmp/slc6_amd64_gcc630/src/GeneratorInterface/Herwig7Interface/src/GeneratorInterfaceHerwig7Interface/HerwigUIProvider.o] Error 1

  • Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 48 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/DQM/SiStripMonitorCluster/src/SiStripMonitorFilter.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/DQM/SiStripMonitorCluster/src/SealModules.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/DQM/SiStripMonitorCluster/src/SiStripMonitorHLT.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/DQM/SiStripMonitorCluster/src/MonitorLTC.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/GeneratorInterface/Herwig7Interface/src/HerwigUIProvider.cc:6:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/GeneratorInterface/Herwig7Interface/interface/HerwigUIProvider.h:7:10: fatal error: 'Herwig/API/HerwigUI.h' file not found
#include 
         ^~~~~~~~~~~~~~~~~~~~~~~
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300/src/GeneratorInterface/Herwig7Interface/src/Herwig7Interface.cc:24:10: fatal error: 'Herwig/API/HerwigAPI.h' file not found
#include 
         ^~~~~~~~~~~~~~~~~~~~~~~~


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
52ba2cf
ad0debb
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21866/25475/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21866/25475/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@fabiocos
Copy link
Contributor

please test workflow 140.52, 140.54 with cms-sw/cmsdist#3642

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 16, 2018

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3642
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25480/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21866/25480/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21866/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21866/140.52_RunHI2010+RunHI2010+RECOHID10+RECOHIR10D11+HARVESTDHI
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21866/140.54_RunPA2013+RunPA2013+RECO_PPbData+HARVEST_PPbData

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2468799
  • DQMHistoTests: Total failures: 230
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2468400
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.47999999986 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@fabiocos
Copy link
Contributor

@dmitrijus This PR seems to fix the problem, unfortunately the blank space changes makes difficult to compare with the committed code. The dependence on externals is just fake (the new Herwig was pending for the 2300 build). If you are satisfied please sign it, I would like to add it at 1100.

@dmitrijus
Copy link
Contributor Author

+1

@dmitrijus
Copy link
Contributor Author

@fabiocos blank space changes and actual changes are in separate commits.

This is the actual change 'commit'.
6d4a6e3

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@dmitrijus I see, thanks. I merge it.

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants