Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compression level in NANOAOD production (10_0_X) #21874

Merged
merged 1 commit into from Jan 24, 2018

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Jan 17, 2018

This forces Merge.py to read the eventcontent definition (for NanoAOD) so that the correct compression settings are set.

This is needed because merging for nanoaod is NOT simply a fastmerge.

The event content is set in the OutputModule in the same way as in cmsDriver
https://github.com/cms-sw/cmssw/blob/master/Configuration/Applications/python/ConfigBuilder.py#L557-L558

As there is no test of Merge.py I simply did the following in interactive python (and seem to give the expected result)

>>> import Merge
>>> p=Merge.mergeProcess(["afile.root"],mergeNANO=True)
>>> print p.dumpPython()
import FWCore.ParameterSet.Config as cms

process = cms.Process("Merge")

process.source = cms.Source("PoolSource",
    fileNames = cms.untracked.vstring("[\'afile.root\']")
)
process.Merged = cms.OutputModule("NanoAODOutputModule",
    compressionAlgorithm = cms.untracked.string('LZMA'),
    compressionLevel = cms.untracked.int32(9),
    fileName = cms.untracked.string('Merged.root'),
    outputCommands = cms.untracked.vstring('drop *', 
        'keep nanoaodFlatTable_*Table_*_*', 
        'keep edmTriggerResults_*_*_*', 
        'keep nanoaodMergeableCounterTable_*Table_*_*', 
        'keep nanoaodUniqueString_nanoMetadata_*_*')
)


process.outputPath = cms.EndPath(process.Merged)

same as #21873

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arizzi for master.

It involves the following packages:

Configuration/DataProcessing

@cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 18, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25505/console Started: 2018/01/18 10:10

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21874/25505/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21874/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2467599
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2467429
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.52000000001 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@fabiocos
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar modified the milestones: CMSSW_10_0_X, CMSSW_10_1_X Jan 24, 2018
@arizzi
Copy link
Contributor Author

arizzi commented Jan 24, 2018

...any reason to hold this? it seems fully signed...

I imagine now I need to reopen a copy of this PR on 10_0_X branch, right?

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c7c8529 into cms-sw:master Jan 24, 2018
@fabiocos
Copy link
Contributor

@arizzi if needed for the 10_0_X scope a back-port is needed. Is it needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants