New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compression level in NANOAOD production (10_0_X) #21874
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21874/2920 |
A new Pull Request was created by @arizzi for master. It involves the following packages: Configuration/DataProcessing @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+operations |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
...any reason to hold this? it seems fully signed... I imagine now I need to reopen a copy of this PR on 10_0_X branch, right? |
+1 |
@arizzi if needed for the 10_0_X scope a back-port is needed. Is it needed? |
This forces Merge.py to read the eventcontent definition (for NanoAOD) so that the correct compression settings are set.
This is needed because merging for nanoaod is NOT simply a fastmerge.
The event content is set in the OutputModule in the same way as in cmsDriver
https://github.com/cms-sw/cmssw/blob/master/Configuration/Applications/python/ConfigBuilder.py#L557-L558
As there is no test of Merge.py I simply did the following in interactive python (and seem to give the expected result)
same as #21873