Modify FileInPath to not lookup file in edmWriteConfigs #21966
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21966/3052 |
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: FWCore/ParameterSet @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Presuming this passes tests and gets approved, which releases should I backport it to? |
| @@ -15,9 +16,12 @@ namespace bf = boost::filesystem; | |||
|
|
|||
| namespace | |||
| { | |||
|
|
|||
| std::atomic<bool> fileLookupDisabled{false}; | |||
There was a problem hiding this comment.
How about the name s_fileLookupDisabled since I have traditionally used s_ for "global" quantities.
There was a problem hiding this comment.
done, that is better. Thanks.
|
@smuzaffar what releases did you change to using softlinks? |
|
@Dr15Jones , @wddgit 10.0.X and 10.1.X |
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-started
labels
|
The code-checks are being triggered in jenkins. |
|
+1 |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21966/3053 |
|
The tests are being triggered in jenkins. |
|
please test |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
No description provided.