Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EGM .cc and python patch for new regression tags in the DB #2202

Merged
merged 2 commits into from Jan 30, 2014

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jan 28, 2014

The PR contains .cc updates and ESPrefers for the new regressions.
The global tags are in preparation.

In general we see moderate to substantial improvements in the photon/electron energy response in all eta regions.

You can see the overview of the training here:
https://indico.cern.ch/getFile.py/access?contribId=3&resId=0&materialId=slides&confId=293993

The result of private reRECO (black) on top of vanilla pre12 (blue) attached for electrons (Zee 50ns PU, 13 TeV):
--- ecal energy only
erecoetrue_hzz50ns_ged_forpre13_lin
erecoetrue_hzz50ns_ged_forpre13_log

--- combined p4 measurement
e4petrue_hzz50ns_ged_forpre13_lin
e4petrue_hzz50ns_ged_forpre13_log

and for photons (Hgg in 50ns PU, 13 TeV):
erecoetrue_hgg50ns_ged_forpre13_lin
erecoetrue_hgg50ns_ged_forpre13_log

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_0_X.

EGM .cc and python patch for new regression tags in the DB

It involves the following packages:

RecoEcal/EgammaClusterAlgos
RecoEcal/EgammaClusterProducers
RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaPhotonAlgos
RecoEgamma/EgammaPhotonProducers
RecoEgamma/EgammaTools
RecoParticleFlow/PFProducer

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor Author

lgray commented Jan 28, 2014

@rcastello Here's the PR for the changes we talked about yesterday. If the new GTs can be made soon we can remove the ESPrefers.

@slava77
Copy link
Contributor

slava77 commented Jan 28, 2014

Hi Lindsey,

What are the _[1-5] in the plots?

@lgray
Copy link
Contributor Author

lgray commented Jan 28, 2014

Slices in increasing eta, roughly 0.5 units of eta per slice.

@slava77
Copy link
Contributor

slava77 commented Jan 29, 2014

working on it

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jan 29, 2014

Set 1 (based on CMSSW_7_0_X_2014-01-28-1400)

Noticeable improvements overall for real electrons

  • 1 TeV ele gun
    all_sign301vsorig_singleelectronpt1000wf16p0c_recogsfelectrons_gedgsfelectrons__reco_obj_correctedecalenergyerror
    all_sign301vsorig_singleelectronpt1000wf16p0c_log10recopfcandidates_particleflow__reco_obj_pt20
  • 35 GeV electrons
    all_sign301vsorig_singleelectron35wf17p0c_recogsfelectrons_gedgsfelectrons__reco_obj_pt
  • 35 GeV electrons DQM: the scale actually went down a bit (is it because this is mean not a peak?)
    ele35_popgen_vs_eta
  • 35 GeV photons
    all_sign301vsorig_singlegammapt35wf19p0c_recophotons_gedphotons__reco_obj_et
  • ttbar PU the EE cluster count went down by more than 20% (it's unclear where this is coming from .. electrons in EE went down by ~4%, from a total of 70)
    ttpu_eeclu_vs_eta

Lindsey, is the EE cluster count expected?

@lgray
Copy link
Contributor Author

lgray commented Jan 29, 2014

The EE cluster count difference is expected, was not expecting it to be so large, but I can tell you what the cause is.
The cut to retain a supercluster is based on the final superCluster.energy(), which changed since you are applying the new regression. In addition, since there is now a 4 GeV minimum pT cut in the mustache regression training, the training sample is significantly more clean from pileup and gives a better response estimate.

@slava77
Copy link
Contributor

slava77 commented Jan 29, 2014

+1

tested 7db3dda in CMSSW_7_0_X_2014-01-28-1400/sign301

Changes are as expected
See comments above for more details

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @ktf can you please take care of it?

@slava77
Copy link
Contributor

slava77 commented Jan 29, 2014

@ktf @davidlange6
Giulio and David,
this is the egamma PR for 700 (pre13), mentioned in the planning meeting yesterday.
It uses ES prefer.
After it's integrated and after the GT is updated, we can get rid of the ESprefer for these payloads

@ktf
Copy link
Contributor

ktf commented Jan 30, 2014

Ok, merging this.

ktf added a commit that referenced this pull request Jan 30, 2014
EGamma updates --  .cc and python patch for new regression tags in the DB
@ktf ktf merged commit 92cbb53 into cms-sw:CMSSW_7_0_X Jan 30, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Advance data for L1Trigger/ L1TCalorimeter, L1TGlobal and L1TMuon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants