CalibCalorimetry/HcalPlugins: Change return type of ESProducer to unique_ptr. #22057
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22057/3176 |
|
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: CalibCalorimetry/HcalPlugins @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22057/3177 |
|
please test |
|
The tests are being triggered in jenkins. |
| ) | ||
| ); | ||
| ReturnType hcalTimeSlew = | ||
| std::make_unique<HcalTimeSlew>(); |
There was a problem hiding this comment.
it would be aesthetically more pleasing to have this now in one line
|
Comparison job queued. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22057/3197 |
|
please test |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
gartung
deleted the
CalibCalorimetry-HcalPlugins-ESProdoucer-returntype
branch
No description provided.