BMTF ZS Unpacker

[panoskatsoulis]

This is the new BMTF Unpacker to support the Zero Suppression firmware feature.
It is tested with about 40M events (unsuppressed format) and it seems to work.

The main purpose of the pull request is to make it able for the forthcoming MWGR#2 for further testing with DQM,and also for validation purposes after the Global Run.

Very probable an updated version will be proposed too.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22058/3178

[cmsbuild]

A new Pull Request was created by @panoskatsoulis for master.

It involves the following packages:

EventFilter/L1TRawToDigi

@nsmith-, @cmsbuild, @thomreis, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25809/console Started: 2018/01/31 17:36

[cmsbuild]

+1
Tested at: c9d073f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22058/25809/summary.html

[cmsbuild]

Comparison job queued.

[thomreis]

Hi @panoskatsoulis
The only difference between the old an the new unpack seems to be in the functions unpacking vs. ZSunpacking. Why not just change the unpacking function in the old unpacker and add the functionality to unpack also the new format, instead of duplicating all the code? The new unpacker can handle the old and the new format anyway so I don't see the need for keeping the old unpacker code.

[panoskatsoulis]

Hi @thomreis
I was developing the code in different files from the beginning and I thought it was a good move to keep for the time the old unpacker in the software in order to be accessible if something go wrong during the next week's run.
The new one in deed unpacks the old format, but I would prefer the old one for the following MWGR to be there, easily accessible via bmtfDigis_cfi.py.
The new one has its own cfi.

If it is not a good idea we can still remove the old one.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22058/25809/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22058/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2463035
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2462865
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.879999999968 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22058/3403

[cmsbuild]

Pull request #22058 was updated. @nsmith-, @cmsbuild, @thomreis, @rekovic can you please check and sign again.

[thomreis]

please abort test

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26114/console Started: 2018/02/15 22:50

[thomreis]

unhold

[cmsbuild]

+1
Tested at: ff282ab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22058/26114/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22058/26114/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2465360
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2465190
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.759999999813 KiB( 22 files compared)
• Checked 111 log files, 9 edm output root files, 27 DQM output files

[thomreis]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[thomreis]

Hi @panoskatsoulis
can you update the PR description please so that it fits for the final version?

[fabiocos]

+1