Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PU ID for btagging #2206

Merged
merged 3 commits into from Feb 13, 2014
Merged

Conversation

acaudron
Copy link

First implementation of a PU category in b-tagging validation code. Allow possibility to identify PU-jets based on gen-jets information. Option not yet switch on for RelVal production.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @acaudron for CMSSW_7_1_X.

Add PU ID for btagging

It involves the following packages:

DQMOffline/RecoB
Validation/RecoB

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@ferencek this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre3, CMSSW_7_1_0_pre2 Feb 5, 2014
@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2206/141/summary.html

@acaudron
Copy link
Author

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Feb 13, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Feb 13, 2014
DQMOffline -- Add  PU ID for btagging
@nclopezo nclopezo merged commit c9d84f8 into cms-sw:CMSSW_7_1_X Feb 13, 2014
@ferencek ferencek deleted the AddPUidForBtagging branch February 13, 2014 22:26
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Advance data for L1Trigger/ L1TCalorimeter, L1TGlobal and L1TMuon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants