fixing missing particle in filter - 93x

[alberto-sanchez]

backport of #22065

[cmsbuild]

A new Pull Request was created by @alberto-sanchez (Alberto Sanchez Hernandez) for CMSSW_9_3_X.

It involves the following packages:

GeneratorInterface/GenFilters

@cmsbuild, @efeyazgan, @perrozzi can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from fixing missing particle in filter #22065

[perrozzi]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25823/console Started: 2018/01/31 23:52

[cmsbuild]

+1
Tested at: fcf00ab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22066/25823/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22066/25823/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 25
• DQMHistoTests: Total histograms compared: 2624448
• DQMHistoTests: Total failures: 233
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2624038
• DQMHistoTests: Total skipped: 177
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
• Checked 105 log files, 8 edm output root files, 25 DQM output files

[perrozzi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@perrozzi do we have a real validation of this filter somewhere?

PS: I see you definitely like TMath::Abs....

[perrozzi]

@alberto-sanchez should comment

[alberto-sanchez]

@perrozzi, @fabiocos : Yes that was way we found the problem, after the filter we has having events where it has failing, digging that we found the cause. attach is a list of channels tested.

genOnly_summary_number.pdf

the problems in the BdToJpsiKstar sample are not related to this filter. The hard work has been made by Stephan Wiederkehr

[perrozzi]

+1

[fabiocos]

+1