Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have TTreeCache work with EmbeddedRootSource #22067

Merged
merged 1 commit into from Feb 1, 2018

Conversation

Dr15Jones
Copy link
Contributor

The EmbeddedRootSource calls different functions of RootFile and
RootTree. This was causing it to not properly use the TTreeCache.
Now we will use the TTreeCache in that case and properly handle
the case where we start reading near the end of the file and then
jump back to the beginning before training has completed.

The EmbeddedRootSource calls different functions of RootFile and
RootTree. This was causing it to not properly use the TTreeCache.
Now we will use the TTreeCache in that case and properly handle
the case where we start reading near the end of the file and then
jump back to the beginning before training has completed.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2018

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_4_X.

It involves the following packages:

IOPool/Input

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25820/console Started: 2018/01/31 23:37

@Dr15Jones
Copy link
Contributor Author

backport #22068

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22067/25820/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22067/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2718773
  • DQMHistoTests: Total failures: 103
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2718508
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 106 log files, 9 edm output root files, 25 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Feb 1, 2018

+1

@cmsbuild cmsbuild merged commit 03f2e34 into cms-sw:CMSSW_9_4_X Feb 1, 2018
@Dr15Jones Dr15Jones deleted the useCacheWithDataMixing_9_4 branch March 22, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants