New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have TTreeCache work with EmbeddedRootSource #22067
Have TTreeCache work with EmbeddedRootSource #22067
Conversation
The EmbeddedRootSource calls different functions of RootFile and RootTree. This was causing it to not properly use the TTreeCache. Now we will use the TTreeCache in that case and properly handle the case where we start reading near the end of the file and then jump back to the beginning before training has completed.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_4_X. It involves the following packages: IOPool/Input @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
The tests are being triggered in jenkins. |
backport #22068 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
The EmbeddedRootSource calls different functions of RootFile and
RootTree. This was causing it to not properly use the TTreeCache.
Now we will use the TTreeCache in that case and properly handle
the case where we start reading near the end of the file and then
jump back to the beginning before training has completed.