[10.0.X] [GT Updates] for HCAL Bug fixes and Jet Probability calibration for btagging

[arunhep]

backport of #22075 and #22137

Summary of changes in Global Tags

2018_MC

• PhaseI 2018 cosmics scenario : 100X_upgrade2018cosmics_realistic_deco_v7 as 100X_upgrade2018cosmics_realistic_deco_v5 with the following changes:

  • update of jet probability calibrations for b-tagging : https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/3464.html
  • HCAL bug fixes : https://indico.cern.ch/event/691337/contributions/2866494/attachments/1586921/2509518/ConditionUpdateProposal20180122.pdf
  • update of leftover ECAL TPG threshold tags
  • update of ECAL and CSC bad channel status

• PhaseI 2018 design scenario : 100X_upgrade2018_design_IdealBS_v5 as 100X_upgrade2018_design_IdealBS_v4 with the following changes:

  • update of jet probability calibrations for b-tagging : https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/3464.html
  • HCAL bug fixes : https://indico.cern.ch/event/691337/contributions/2866494/attachments/1586921/2509518/ConditionUpdateProposal20180122.pdf

• PhaseI 2018 realistic scenario : 100X_upgrade2018_realistic_v9 as 100X_upgrade2018_realistic_v7 with the following changes:

  • update of jet probability calibrations for b-tagging : https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/3464.html
  • HCAL bug fixes : https://indico.cern.ch/event/691337/contributions/2866494/attachments/1586921/2509518/ConditionUpdateProposal20180122.pdf
  • update of ECAL and CSC bad channel status

2017_MC

• PhaseI 2017 cosmics peak scenario : 100X_mc2017cosmics_realistic_peak_v3 as 100X_mc2017cosmics_realistic_peak_v2 with the following changes:

  • update of jet probability calibrations for b-tagging : https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/3464.html

• PhaseI 2017 cosmics scenario : 100X_mc2017cosmics_realistic_deco_v3 as 100X_mc2017cosmics_realistic_deco_v2 with the following changes:

  • update of jet probability calibrations for b-tagging : https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/3464.html

• PhaseI 2017 design scenario : 100X_mc2017_design_IdealBS_v3 as 100X_mc2017_design_IdealBS_v2 with the following changes:

  • update of jet probability calibrations for b-tagging : https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/3464.html

• PhaseI 2017 realistic scenario : 100X_mc2017_realistic_v3 as 100X_mc2017_realistic_v2 with the following changes:

  • update of jet probability calibrations for b-tagging : https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/3464.html

[cmsbuild]

A new Pull Request was created by @arunhep (Arun Kumar) for CMSSW_10_0_X.

It involves the following packages:

Configuration/AlCa

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from [10.1.X] [GT Updates] for HCAL Bug fixes and Jet Probability calibration for btagging #22075

[arunhep]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25852/console Started: 2018/02/01 19:45

[cmsbuild]

+1
Tested at: a7ebe47
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22078/25852/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22078/25852/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22078/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 921 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2468773
• DQMHistoTests: Total failures: 1122
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2467482
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.990000000143 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[arunhep]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25956/console Started: 2018/02/07 20:59

[cmsbuild]

+1
Tested at: a04df83
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22078/25956/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22078/25956/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22078/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 1549 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2469477
• DQMHistoTests: Total failures: 1958
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2467350
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.750000000109 KiB( 22 files compared)
• Checked 111 log files, 9 edm output root files, 27 DQM output files

[arunhep]

@fabiocos @franzoni
even with higher statistics (50 events), the distributions are not exactly same.

look at the this diagram.

Red : with this PR (new GT)
Blue : old GT

DQM root files can be found here : /afs/cern.ch/user/a/arun/public/PRTest_22078

now I am running the workflow with a GT containing only the HCAL changes and rest of the conditions are same as old GT.

[arunhep]

@fabiocos @franzoni
I have checked following cases by running wf 10824 on 50 events :

1. New GT : all the updates present : GT from this PR
2. Old GT : reference GT from this PR
3. Keeping only HCAL condition updates on the top of old GT --> No change in Tracking
4. Keeping HCAL + ECAL channel status --> No change in tracking
5. Keeping HCAL + ECAL + CSC channel status --> No change in tracking

so once we add new jet probability calibration in GT then we see the change in tracking.
all the files can be found here : /afs/cern.ch/user/a/arun/public/PRTest_22078

[arunhep]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[makortel]

so once we add new jet probability calibration in GT then we see the change in tracking.

I can not understand how a(ny) change in btagging would affect tracking. @VinInn

all the files can be found here : /afs/cern.ch/user/a/arun/public/PRTest_22078

Thanks for the files, I made the usual TRK validation plots
https://cms-tracking-validation.web.cern.ch/cms-tracking-validation/PR/CMSSW_10_0_X_PR22078/
and according to them it is actually the "HCAL updates" which cause the change. I can see changes already in initialStepPreSplitting tracks
https://cms-tracking-validation.web.cern.ch/cms-tracking-validation/PR/CMSSW_10_0_X_PR22078/plots_building_initialStepPreSplitting/effandfakePtEtaPhi.pdf
which actually doesn't make much sense either as the first step in tracking depending on calorimeters comes after those tracks (cluster splitting at the end of that iteration).

Or did I understand the file naming incorrectly?

[arunhep]

@makortel

when I claimed no changes with HCAL updates then I checked only few histograms and not all of them. One of the checked ones is the one posted in above comments.

thanks for the detailed checks. Here are definitions of files names and more details:

1. DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO_oldGT.root --> DQM file made with old GT (reference GT in this PR : 100X_upgrade2018_realistic_v7)
2. DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO_NEWGT.root --> DQM file made with old GT (target GT in this PR : 100X_upgrade2018_realistic_v10)
3. DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO_onlyHCAL.root --> DQM file made with GT only containing HCAL changes from this PR : diff of GT with reference one : https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/100X_upgrade2018_realistic_Candidate_2018_02_08_15_20_01/100X_upgrade2018_realistic_v7
4. DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO_HCALECAL.root --> DQM file made with GT containing HCAL + ECAL changes from this PR : diff of GT with reference one : https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/100X_upgrade2018_realistic_Candidate_2018_02_08_16_17_28/100X_upgrade2018_realistic_v7
5. DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO_HCALECALCSC.root --> DQM file made with GT containing HCAL + ECAL + CSC changes from this PR : diff of GT with reference one : https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/100X_upgrade2018_realistic_Candidate_2018_02_08_18_02_55/100X_upgrade2018_realistic_v7

[mmusich]

Hi all,
isn't this the usual case of getting random changes at the digitizer level, due to random number sequences when some new condition affecting the DIGI step enters the Global Tag?
According to https://twiki.cern.ch/twiki/bin/viewauth/CMS/AlCaDBHLT e.g. HcalGainsRcd is consumed by the HCAL digitizer.
There is plenty of differences already at the level of strip digis: https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_0_X_2018-02-07-1100+22078/24962/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/GlobalDigisV_SiStrips.html

[makortel]

Thanks @mmusich, I didn't look carefully-enough that DIGI was affected. I fully agree on your diagnosis.