Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report CPU time spent in child processes of ExternalLHEProducer [9_4] #22101

Merged
merged 2 commits into from Apr 10, 2018

Conversation

Dr15Jones
Copy link
Contributor

When accounting for CPU time used by a cmsRun job, we need to also include the CPU time of the child processes launched by ExternalLHEProducer.

The CPU time is not accumulated per stream and the place where we
want addToCPUTime to be called is during global begin run.
Report the CPU time spent in child processes launched.
@Dr15Jones
Copy link
Contributor Author

backport #22100

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_4_X.

It involves the following packages:

FWCore/Services
FWCore/Utilities
GeneratorInterface/LHEInterface

@cmsbuild, @smuzaffar, @efeyazgan, @Dr15Jones, @perrozzi can you please review it and eventually sign? Thanks.
@mkirsano, @makortel, @felicepantaleo, @wddgit, @Martin-Grunewald, @agrohsje, @alberto-sanchez, @ebrondol this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25881/console Started: 2018/02/02 21:14

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

Comparison job queued.

@perrozzi
Copy link
Contributor

perrozzi commented Feb 2, 2018

I guess this is needed in 93x (used for GEN-SIM) and not 94x (used for DIGI-RECO) right?

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22101/25881/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22101/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2718773
  • DQMHistoTests: Total failures: 100
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2718511
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 106 log files, 9 edm output root files, 25 DQM output files

@Dr15Jones
Copy link
Contributor Author

@perrozzi see #22103

@Dr15Jones
Copy link
Contributor Author

+1

@perrozzi
Copy link
Contributor

perrozzi commented Feb 9, 2018

sorry to ask again: is this really needed in 94x?

@fabiocos
Copy link
Contributor

fabiocos commented Apr 6, 2018

@perrozzi This is not strongly needed for 94X, as no massive GEN production is expected here to my knowledge, but it is in production in master since quite sometime, and it doesn't harm either

@perrozzi
Copy link
Contributor

perrozzi commented Apr 9, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 94af51d into cms-sw:CMSSW_9_4_X Apr 10, 2018
@Dr15Jones Dr15Jones deleted the extraCPUTime_9_4 branch April 26, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants