Rerunning MVA based tauIDs for "run2_miniAOD_94XFall17" and "run2_miniAOD_80XLegacy" eras + one additional fix in boostedTau reconstruction for miniAOD

[roger-wolf]

Dear colleagues,

following Slava's proposal here (#21977) this is a commit to define a new era run2_miniAOD_94XFall17 which acts on PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py (L326ff). No further changes are applied local tests show that the change acts as expected.

Cheers,
Roger

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22105/3237

[cmsbuild]

A new Pull Request was created by @roger-wolf (Roger Wolf) for master.

It involves the following packages:

Configuration/Eras
Configuration/StandardSequences
PhysicsTools/PatAlgos
RecoTauTag/Configuration

@perrotta, @monttj, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @TaiSakuma, @gouskos, @felicepantaleo, @rappoccio, @Martin-Grunewald, @ahinzmann, @seemasharmafnal, @mmarionncern, @imarches, @makortel, @acaudron, @jdolen, @ferencek, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @ebrondol, @dgulhan, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25892/console Started: 2018/02/03 18:41

[cmsbuild]

+1
Tested at: d83c106
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22105/25892/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22105/25892/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22105/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2465763
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2465593
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.600000000086 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[slava77]

@roger-wolf
the same run2_miniAOD_94XFall17 era was now merged and this PR has a conflict now.
please rebase this on top of the upcoming IB (CMSSW_10_1_X_2018-02-06-2300 or later)

[davidlange6]

Your PR is unmergeable. Please have a look and possibly rebase it.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22105/3382

[cmsbuild]

Pull request #22105 was updated. @perrotta, @cmsbuild, @monttj, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26096/console Started: 2018/02/15 16:13

[cmsbuild]

+1
Tested at: 31780a5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22105/26096/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c7fa0d1
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22105/26096/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22105/26096/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22105/26096/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 137 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2465360
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2465190
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.03999999985 KiB( 22 files compared)
• Checked 111 log files, 9 edm output root files, 27 DQM output files

[slava77]

+1

for #22105 31780a5

• implementation is in line with the description (run2_miniAOD_94XFall17 is introduced to handle miniAOD workflows using inputs from 94XFall17)
• jenkins tests pass and comparisons with baseline show small differences only in the plots of slimmedTausBoosted
• tested locally with Rerunning MVA based tauIDs for "run2_miniAOD_94XFall17" and "run2_miniAOD_80XLegacy" eras + one additional fix in boostedTau reconstruction for miniAOD #22105 df981f6 with changes as expected by rerunning PAT on standard Run2_2017, on run2_miniAOD_94XFall17 (manual setup), and on run2_miniAOD_80XLegacy (wf 1325.5 and wf 136.7721:
  • slimmedBoostedTaus change slightly everywhere as expected from the change in the modifier based on PFRecoTauMassPlugin
  • slimmedTaus change only in run2_miniAOD_94XFall17 (in Run2_2017 there is no change because IDs are not remade, while in run2_miniAOD_80XLegacy all tau reco was already remade).

E.g. in run2_miniAOD_94XFall17
the "float" (non-binary) discriminator hpsPFTauDiscriminationByIsolationMVArun2v1DBoldDMwLTraw has changed

and hpsPFTauDiscriminationByVVLooseIsolationMVArun2v1DBoldDMwLT is now filled

[fabiocos]

+1

[fabiocos]

merge