fix packing of 2x32 in 64 bits (10.0.x)

[fwyzard]

backport #21982:

@VinInn wrote:

the title says all.
We noticed that in MC (and never in Data) often the last word of a Det comes after the first word of the successive det....

Purely technical affecting only digitization.

no regression expected.

[fwyzard]

type bugfix

[fwyzard]

backport #21982

[fwyzard]

@cmsbuild please test

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_10_0_X.

It involves the following packages:

EventFilter/SiPixelRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ebrondol, @dkotlins, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from fix packing of 2x32 in 64 bits #21982

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25913/console Started: 2018/02/06 11:09

[cmsbuild]

+1
Tested at: 66d7373
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22123/25913/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22123/25913/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22123/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2468773
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2468603
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.1 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[fabiocos]

@slava77 any objection on this fix backport?

[slava77]

+1

for #22123 66d7373

• the backport is correct; there should be no effect on the reconstructed quantities
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1