Strip APV gains dumped in TTree

[jpriscia]

SiStripApvGainReader modified to dump gains in a TTree
Executable version of the cfg also added

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22129/3255

[cmsbuild]

A new Pull Request was created by @jpriscia for master.

It involves the following packages:

CondTools/SiStrip

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[boudoul]

Hi @jpriscia , thanks for this development - Just a suggestion : In the process of improving the documentation of our packages, it might be good to start to add a readme file explaining what is this APV gain reader and usage of the cfg - Thank you

[ggovi]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25944/console Started: 2018/02/07 14:48

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22129/3271

[cmsbuild]

Pull request #22129 was updated. @ggovi, @cmsbuild can you please check and sign again.

[jpriscia]

Hi @boudoul , readme added. Cheers

[boudoul]

Thanks, appreciated !

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22129/26045/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22129/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2465360
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2465190
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.00999999982 KiB( 22 files compared)
• Checked 111 log files, 9 edm output root files, 27 DQM output files

[mmusich]

the error reported in the addOn tests is not related to the code changes.

----- Begin Fatal Exception 13-Feb-2018 18:22:47 CET-----------------------
An exception of category 'FastSimulation' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 16 stream: 3
   [1] Running path 'simulation_step'
   [2] Calling method for module FastSimProducer/'fastSimProducer'
Exception Message:
HelixTrajectory: should not be reached (no solution).
----- End Fatal Exception -------------------------------------------------

can tests be restarted?

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26170/console Started: 2018/02/19 17:05

[cmsbuild]

+1
Tested at: 48d2b6d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22129/26170/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22129/26170/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2465360
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2465190
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.779999999875 KiB( 22 files compared)
• Checked 111 log files, 9 edm output root files, 27 DQM output files

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1