Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0.X] fix typo in SiStripBackPlaneCorrectionFakeESSource plugin definition name #22140

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 7, 2018

backport of #22136.
Fixing a typo in the definition of the SiStripBackPlaneCorrectionFakeESSource.cc plugin name, that conflicts with the usage in the python fragment

siStripBackPlaneCorrectionFakeESSource = cms.ESSource("SiStripBackPlaneCorrectionFakeESSource",

Discovered thanks to work done for resurrecting the CosmicRack Tracking details.

@cmsbuild cmsbuild added this to the CMSSW_10_0_X milestone Feb 7, 2018
@mmusich
Copy link
Contributor Author

mmusich commented Feb 7, 2018

type bugifx

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_10_0_X.

It involves the following packages:

CalibTracker/SiStripESProducers

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @jlagram, @mmusich, @gbenelli, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ghellwig
Copy link

ghellwig commented Feb 7, 2018

please test

@ghellwig
Copy link

ghellwig commented Feb 7, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25937/console Started: 2018/02/07 13:17

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22140/25937/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22140/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2468773
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2468603
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.08999999988 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Feb 8, 2018

+1

@cmsbuild cmsbuild merged commit 46364c5 into cms-sw:CMSSW_10_0_X Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants