Geant4 Sensitive Detectors update 4: revised selection of particle type for shower libraries #22145

civanch · 2018-02-07T14:47:32Z

This PR was discussed at the SIM meeting:
https://indico.cern.ch/event/702324/contributions/2885360/attachments/1596130/2528121/VI20180206.pdf

Several static methods are added to identify Geant4 particle type. These methods are used to select shower library branches with EM or hadronic hits. Hyperons and exotic particles will not any more treated as "hadrons", they should decay and only decay products will provide showers. Due to that, in many workflows one can expect different simulation histories and only statistical comparison of results is possible.

HF hits are sampled differently:

for e+-, gamma and stable hadrons SL is called, if kinetic energy of a particle is below 50 MeV the particle is killed 2) Hyperons are ignored - no hits are created, allowing them to decay first
If baryon number of a particle is above 0 then kinetic energy is used for SL interpolation and not total energy. DUe to these modifications low-energy ions does not produce any more extra hits

CastorSD class was changed more in order to use this opportunity when results are not identical:

many commented lines removed; 2) fabs -> std::abs 3) early check of primary particle type and do not perform computations if a particle is not for shower library and cannot produce Cerenkov light.

Additionally some commented lines and unused variables are removed in other classes.

cmsbuild · 2018-02-07T14:47:52Z

The code-checks are being triggered in jenkins.

civanch · 2018-02-07T14:53:15Z

please test

cmsbuild · 2018-02-07T14:53:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22145/3275

cmsbuild · 2018-02-07T14:54:14Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25948/console Started: 2018/02/07 19:42

cmsbuild · 2018-02-07T14:54:16Z

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4CMS/Calo
SimG4CMS/Forward
SimG4CMS/Tracker
SimG4Core/Notification

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

civanch · 2018-02-07T14:56:47Z

@bsunanda , @kpedro88 - we discussed this at the meeting

cmsbuild · 2018-02-07T21:04:07Z

+1
Tested at: 4c2fe89
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22145/25948/summary.html

cmsbuild · 2018-02-07T21:04:10Z

Comparison job queued.

cmsbuild · 2018-02-08T01:01:04Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22145/25948/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22145/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 22451 differences found in the comparisons
DQMHistoTests: Total files compared: 27
DQMHistoTests: Total histograms compared: 2466491
DQMHistoTests: Total failures: 83949
DQMHistoTests: Total nulls: 4
DQMHistoTests: Total successes: 2382369
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.909999999938 KiB( 22 files compared)
Checked 111 log files, 9 edm output root files, 27 DQM output files

civanch · 2018-02-08T08:46:54Z

+1
differences expected due to change of SIM histories

cmsbuild · 2018-02-22T21:43:35Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22145/26234/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 26041 differences found in the comparisons
DQMHistoTests: Total files compared: 28
DQMHistoTests: Total histograms compared: 2498056
DQMHistoTests: Total failures: 105196
DQMHistoTests: Total nulls: 2
DQMHistoTests: Total successes: 2392682
DQMHistoTests: Total skipped: 176
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.989999999969 KiB( 23 files compared)
Checked 115 log files, 9 edm output root files, 28 DQM output files

civanch · 2018-02-23T08:52:35Z

+1

fabiocos · 2018-03-01T12:41:52Z

@civanch could you please document (may be in the next simulation meeting) the differences that you have observed, so as we may quantify them? If they are really a few percent effect they do not look totally irrelevant to me.

abdoulline · 2018-03-02T07:29:10Z

Our (HCAL) 50 GeV single-pion Calo-scan test may not be very useful to spot fine details, as due to the change in SIM rndm sequence(s), the results at this level of stat (50k ev) fluctuate within several % easily...
But at least there is no major issues observed:
https://cms-cpt-software.web.cern.ch/cms-cpt-software/General/Validation/SVSuite/HCAL/calo_scan_single_pi/10_X/10_1_0_pre1_HFfix_vs_10_1_0_pre1_SinglePi/

civanch · 2018-03-02T13:36:39Z

10k MinBias events - a small suppression of the high energy tail:
http://test-civanch.web.cern.ch/test-civanch/run_matrix/res_mb/e_HF.png

civanch · 2018-03-07T18:25:20Z

The test of hits was done using 50k events. The results:
http://test-civanch.web.cern.ch/test-civanch/run_matrix/res_mb/en_EE.png
http://test-civanch.web.cern.ch/test-civanch/run_matrix/res_mb/en_HE.png
http://test-civanch.web.cern.ch/test-civanch/run_matrix/res_mb/en_HF.png
http://test-civanch.web.cern.ch/test-civanch/run_matrix/res_mb/en_Castor.png

fabiocos · 2018-03-12T10:33:49Z

@civanch thanks, how were the histograms normalized? I would expect to see no difference, within statistics, for both EE and HE, right?

civanch · 2018-03-12T11:43:23Z

@fabiocos , statistically distributions are not in contrudiction I guess. There is an expresion of some systematics but I would not say it isstatistically significant. Also Hypérons and ions do not produce HF showers, this may slightly change hits in HE and EE. Normalisation of shown histograms is not done - the same number of events 50k is used for both cases.

fabiocos · 2018-04-13T09:10:32Z

@civanch @franzoni @klute as discussed, this will enter into a test build on top of 10_2_0_pre2, and a few significant dedicated test samples with decent statistics should be agreed with JetMET to test its effect on jets in HF and MET

fabiocos · 2018-04-20T14:17:32Z

unhold

cmsbuild · 2018-04-20T14:17:53Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-04-20T14:20:58Z

@civanch @franzoni @klute as agreed we will check this PR in 10_2_0_pre2 . As the expected effect of this PR is small, in order to make the validation work lighter we can "plan for success", as David likes, and integrate it into the pre-release, assuming that only in case unexpected effects are observed we make a dedicated build where this PR is removed for further investigations.

fabiocos · 2018-04-22T14:27:27Z

+1

civanch added 2 commits February 7, 2018 15:21

select particle type for shower libraries using utility

3efa343

removed commented lines

4c2fe89

cmsbuild added this to the CMSSW_10_1_X milestone Feb 7, 2018

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures simulation-pending tests-pending labels Feb 7, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 7, 2018

cmsbuild added tests-started and removed tests-pending labels Feb 7, 2018

cmsbuild added tests-approved and removed tests-started labels Feb 7, 2018

cmsbuild added comparison-available and removed comparison-pending labels Feb 8, 2018

cmsbuild added fully-signed and removed pending-signatures simulation-pending labels Feb 8, 2018

cmsbuild added the tests-approved label Feb 22, 2018

cmsbuild added comparison-available and removed comparison-pending labels Feb 22, 2018

cmsbuild added simulation-approved and removed simulation-pending labels Feb 23, 2018

This was referenced Mar 19, 2018

Test GT Queues: Extended 2018 without Totem #22659

Closed

Remove Totem Detectors from 2018 Geometry Scenarios #22657

Merged

smuzaffar modified the milestones: CMSSW_10_1_X, CMSSW_10_2_X Mar 29, 2018

This was referenced Mar 29, 2018

SimG4CMS/Forward: Fix clang warnings -Woverloaded-virtual -Wself-assign #22789

Closed

CASTOR reconstruction and simulation updates #22424

Merged

cmsbuild added fully-signed and removed hold pending-signatures labels Apr 20, 2018

cmsbuild added orp-approved and removed orp-pending labels Apr 22, 2018

cmsbuild merged commit caf9c33 into cms-sw:master Apr 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Geant4 Sensitive Detectors update 4: revised selection of particle type for shower libraries #22145

Geant4 Sensitive Detectors update 4: revised selection of particle type for shower libraries #22145

civanch commented Feb 7, 2018 •

edited

cmsbuild commented Feb 7, 2018

civanch commented Feb 7, 2018

cmsbuild commented Feb 7, 2018

cmsbuild commented Feb 7, 2018 •

edited

cmsbuild commented Feb 7, 2018

civanch commented Feb 7, 2018

cmsbuild commented Feb 7, 2018

cmsbuild commented Feb 7, 2018

cmsbuild commented Feb 8, 2018

civanch commented Feb 8, 2018

cmsbuild commented Feb 22, 2018

civanch commented Feb 23, 2018

fabiocos commented Mar 1, 2018

abdoulline commented Mar 2, 2018

civanch commented Mar 2, 2018

civanch commented Mar 7, 2018

fabiocos commented Mar 12, 2018

civanch commented Mar 12, 2018

fabiocos commented Apr 13, 2018

fabiocos commented Apr 20, 2018

cmsbuild commented Apr 20, 2018

fabiocos commented Apr 20, 2018

fabiocos commented Apr 22, 2018

Geant4 Sensitive Detectors update 4: revised selection of particle type for shower libraries #22145

Geant4 Sensitive Detectors update 4: revised selection of particle type for shower libraries #22145

Conversation

civanch commented Feb 7, 2018 • edited

cmsbuild commented Feb 7, 2018

civanch commented Feb 7, 2018

cmsbuild commented Feb 7, 2018

cmsbuild commented Feb 7, 2018 • edited

cmsbuild commented Feb 7, 2018

civanch commented Feb 7, 2018

cmsbuild commented Feb 7, 2018

cmsbuild commented Feb 7, 2018

cmsbuild commented Feb 8, 2018

civanch commented Feb 8, 2018

cmsbuild commented Feb 22, 2018

civanch commented Feb 23, 2018

fabiocos commented Mar 1, 2018

abdoulline commented Mar 2, 2018

civanch commented Mar 2, 2018

civanch commented Mar 7, 2018

fabiocos commented Mar 12, 2018

civanch commented Mar 12, 2018

fabiocos commented Apr 13, 2018

fabiocos commented Apr 20, 2018

cmsbuild commented Apr 20, 2018

fabiocos commented Apr 20, 2018

fabiocos commented Apr 22, 2018

civanch commented Feb 7, 2018 •

edited

cmsbuild commented Feb 7, 2018 •

edited