New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to measure time in the EventSetup #22163
Conversation
Uses the Timing Service to measure to two time totals. First, the time while threads are blocked by the mutex in DataProxy::get. Second, the time to run the getImpl function to fill the data cache after the mutex lock has been obtained.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22163/3301 |
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@fwyzard At one point you asked to be notified about new signals in the Framework. This PR adds 3 signals related to the EventSetup. You can probably safely ignore them although they might be of interest to you. The Timing service uses them (and also there is an option for the Tracer service to use them). |
please test |
The tests are being triggered in jenkins. |
Thanks David,
as you suggested, I subscribed to get notifications about FWCore/Services
:-)
Do you think it would make sense to have a tighter integration between the
framework and the FastTimerService ?
.A
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
Uses the Timing Service to measure to two time totals.
First, the time while threads are blocked by the mutex in
DataProxy::get. Second, the time to run the getImpl function
to fill the data cache after the mutex lock has been obtained.