Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMTF unpacked muons match uGMT unpacked muons, backport to 10_0_X #22169

Merged
merged 6 commits into from Feb 13, 2018

Conversation

abrinke1
Copy link
Contributor

@abrinke1 abrinke1 commented Feb 9, 2018

@thomreis
Back-port of PR #22090 to 10_0_X for DQM

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2018

A new Pull Request was created by @abrinke1 for CMSSW_10_0_X.

It involves the following packages:

EventFilter/L1TRawToDigi
L1Trigger/L1TMuonEndCap

@nsmith-, @cmsbuild, @thomreis, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor

thomreis commented Feb 9, 2018

please test

@thomreis
Copy link
Contributor

thomreis commented Feb 9, 2018

backport of #22090

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25996/console Started: 2018/02/09 18:46

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22169/25996/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22169/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2468146
  • DQMHistoTests: Total failures: 35
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2467942
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.910000000003 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@thomreis
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5b6758e into cms-sw:CMSSW_10_0_X Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants